From mboxrd@z Thu Jan 1 00:00:00 1970 From: jamal Subject: Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify() Date: Mon, 14 Aug 2006 19:43:11 -0400 Message-ID: <1155598991.6946.42.camel@jzny2> References: <20060814213718.580598840@postel.suug.ch> <20060814214341.834971519@postel.suug.ch> Reply-To: hadi@cyberus.ca Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org Return-path: Received: from mx03.cybersurf.com ([209.197.145.106]:56241 "EHLO mx03.cybersurf.com") by vger.kernel.org with ESMTP id S932465AbWHNXni (ORCPT ); Mon, 14 Aug 2006 19:43:38 -0400 Received: from mail.cyberus.ca ([209.197.145.21]) by mx03.cybersurf.com with esmtp (Exim 4.30) id 1GCm5k-00034O-DD for netdev@vger.kernel.org; Mon, 14 Aug 2006 19:43:32 -0400 To: Alexey Kuznetsov , Thomas Graf In-Reply-To: <20060814214341.834971519@postel.suug.ch> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 2006-14-08 at 00:00 +0200, Thomas Graf wrote: > plain text document attachment (rtnl_convert_ip6_addr) > Fixes a wrong use of current->pid as netlink pid. If i am not mistaken: Some of these removals of current->pid will affect users such as quagga, zebra, vrrpd etc. If those specific users are not affected, please ignore the rest of my comments. I realize mr. Kuznetsov submitted at least one patch in the past to do something similar to this. IMO, I believe there is a strong case that can be made for events that were caused by non-netlink users such as ioctls that could at least be multicast with current->pid. In other words an exception case for only this scenario. In such a case there is no unicast netlink message. It would also be acceptable if the quagga etc folks could meet their goals some other way. cheers, jamal