netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: netdev@vger.kernel.org
Cc: Jiri Benc <jbenc@suse.cz>, Jouni Malinen <jkm@devicescape.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: 802.11 headers
Date: Thu, 17 Aug 2006 09:48:19 +0200	[thread overview]
Message-ID: <1155800899.3653.13.camel@ux156> (raw)

The d80211 headers are messy. Before merging, we definitely need to
clean them up and split them between userland-visible and kernel-only
headers, or else ... ;)

My current thoughts:
 - net/d80211_common.h can die sometime soon due to being replaced with
   linux/nl80211.h (to be published today).
 - net/d80211_mgmt.h needs cleaning up (I know Michael has been doing
   some of that), and then should probably be renamed to
   linux/ieee80211.h and be userland-visible, and contain a bunch of
   other frame definitions as well. A bit like net/ieee80211.h now,
   though more protocol-centric.
 - net/ieee80211_radiotap.h should be userland-visible, and hence
   linux/radiotap.h or such.
 - net/d80211_shared.h probably has the same fate as
   net/d80211_common.h, except for the _RATE_* thingies, but I'm not
   sure why they should be userland-visible.
 - net/d80211.h can stay there as-is, it's in-kernel only API.
 
Or put another way, my suggestions:
 - put all in-kernel API (for drivers) into net/d80211.h
 - put stuff defined in the IEEE 802.11 specification series into
   linux/ieee80211.h, make user-visible (headers-y in Kbuild!). This
   serves just as a reference. It's not really necessary that the kernel
   ships this, but we need it in the kernel and probably won't be
   pulling it from some other source. Besides, I wouldn't know where
   else to maintain it.
 - radiotap simply moves to linux/ and gets to be userland-visible. Of
   course, d80211 should actually start using it too ;)
 - all the other userland stuff seems to be configuration related and
   hence moves over to linux/nl80211.h

Comments?

johannes


             reply	other threads:[~2006-08-17  7:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-17  7:48 Johannes Berg [this message]
2006-08-17 12:34 ` 802.11 headers Jiri Benc
2006-08-17 12:43   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1155800899.3653.13.camel@ux156 \
    --to=johannes@sipsolutions.net \
    --cc=dwmw2@infradead.org \
    --cc=jbenc@suse.cz \
    --cc=jkm@devicescape.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).