From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Eric Sesterhenn <snakebyte@gmx.de>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [Patch] Signedness issue in drivers/net/3c515.c
Date: Mon, 21 Aug 2006 23:13:25 +0100 [thread overview]
Message-ID: <1156198406.18887.81.camel@localhost.localdomain> (raw)
In-Reply-To: <20060821140558.4cfee23c.akpm@osdl.org>
Ar Llu, 2006-08-21 am 14:05 -0700, ysgrifennodd Andrew Morton:
> /* Wait for the stall to complete. */
> for (i = 20; i >= 0; i--)
> if ((inw(ioaddr + EL3_STATUS) & CmdInProgress) == 0)
> break;
>
> Your fix will convert this indefinit wait into a bounded one. It might
> cause the driver to malfunction.
The change is correct. The docs guarantee it can't take that long.
prev parent reply other threads:[~2006-08-21 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1156009077.18374.1.camel@alice>
2006-08-21 21:05 ` [Patch] Signedness issue in drivers/net/3c515.c Andrew Morton
2006-08-21 22:13 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156198406.18887.81.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox