Re: [PATCH 06/18] d80211: rework rate control registration

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2006-08-21 at 21:19 +0200, Jiri Benc wrote:

> This is not so easy. The locking around rate control modules is
> currently totally wrecked. I started cleaning this up before I left for
> vacation and haven't time to finish it yet.
> 
> My patches do:
> - rename of rate control files (rate_control.h => ieee80211_rate.h)
> - introduce a new ieee80211_rate.c file (I'm trying to gradually move
>   things out of the big ieee80211.c)
> - fix locking (Yes, it is broken. Yes, I can prove it.)
> - allow different rate control algorithm for each wiphy
> - proper and race-free rate control modules loading

I do the same here, actually, except for filenames. And then I simply
rely on module refcounting, which is fine IMHO.

And I'm pretty sure that with locking around all the
registration/unregistration it's fine. And I think that in this case,
having the list_head in the rate control ops structure is fine because
no rate control module can reasonably register it twice anyway.

However, I can drop the patch if you want to. I'm not particularly
attached to it ;)

> Sorry for not cleanly stating this before :-(

Do you have anything else you're working on? :P

johannes