From: Johannes Berg <johannes@sipsolutions.net>
To: David Kimdon <david.kimdon@devicescape.com>
Cc: netdev@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Jiri Benc <jbenc@suse.cz>
Subject: Re: [patch 3/5] d80211: fix interface removal
Date: Wed, 23 Aug 2006 09:20:28 +0200 [thread overview]
Message-ID: <1156317628.3629.13.camel@ux156> (raw)
In-Reply-To: <20060822173353.GD12500@devicescape.com>
On Tue, 2006-08-22 at 10:33 -0700, David Kimdon wrote:
> + if (param->u.if_info.type == HOSTAP_IF_WDS) {
> + type = IEEE80211_IF_TYPE_WDS;
> + } else if (param->u.if_info.type == HOSTAP_IF_VLAN) {
> + type = IEEE80211_IF_TYPE_VLAN;
> + } else if (param->u.if_info.type == HOSTAP_IF_BSS) {
> + type = IEEE80211_IF_TYPE_AP;
> + } else if (param->u.if_info.type == HOSTAP_IF_STA) {
> + type = IEEE80211_IF_TYPE_STA;
> + } else {
> + return -EINVAL;
> }
IMHO that'd look better as a switch(). Or maybe even a small static
array to map them and just some bounds checking code?
Also, spaces instead of tab on the last added line.
johannes
next prev parent reply other threads:[~2006-08-23 7:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060822173241.313859000@devicescape.com>
2006-08-22 17:33 ` [patch 1/5] d80211: allow for large scan results David Kimdon
2006-08-22 17:33 ` [patch 2/5] d80211: fix multiple device support David Kimdon
2006-08-22 17:33 ` [patch 3/5] d80211: fix interface removal David Kimdon
2006-08-23 7:20 ` Johannes Berg [this message]
2006-08-23 16:05 ` Jiri Benc
2006-08-22 17:34 ` [patch 4/5] d80211/bcm43xx: fix build for ARM David Kimdon
2006-08-22 18:58 ` Michael Buesch
2006-08-22 17:34 ` [patch 5/5] d80211: add ioctl to stop data frame tx David Kimdon
2006-08-23 7:25 ` Johannes Berg
2006-08-23 16:09 ` Jiri Benc
2006-08-28 18:34 ` Elliot Schwartz
2006-08-23 19:20 ` Simon Barber
2006-08-28 18:29 ` Elliot Schwartz
2006-08-29 7:30 ` Johannes Berg
2006-08-29 11:45 ` John W. Linville
2006-08-29 18:39 ` Jouni Malinen
2006-08-30 7:26 ` Johannes Berg
2006-08-30 16:01 ` Jouni Malinen
2006-08-31 7:23 ` Johannes Berg
2006-09-22 12:13 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156317628.3629.13.camel@ux156 \
--to=johannes@sipsolutions.net \
--cc=david.kimdon@devicescape.com \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).