Re: [RFC] add nl80211

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2006-08-24 at 16:36 +0200, Thomas Graf wrote:

> Might want to put this in a header so userspace can see the limit.

Good point, thanks.

> In your case I'd call it GET_CMDLIST and NEW_CMDLIST which
> means you request a command list with GET_CMDLIST and
> receive the answer with a CMD_NEWLIST message.

Yeah, ok, I think I understood this now :)


> I'd just use the command id as attribute type:
> 
> 	NLA_PUT_FLAG(msg, NL80211_CMD_GET_COMMANDS);
> 	NLA_PUT_FLAG(msg, NL80211_CMD_GET_WIPHYS);
> 	....
> 
> This makes checking avaibility of a command as easy as
> accessing an array for userspace.

Good point. However, userspace will need to be aware to parse this with
the max_cmd instead of max_attr :)

> > +	err = genlmsg_end(msg, hdr);
> > +	if (err)
> > +		goto msg_free;
> 
> genlmsg_end() can't fail, it just returns skb->len which
> is only of importance while dumping to see if there is
> still more to dump or not.

Whoops :)

> You might want to send out notifications for various events such as the
> additiona and deletion of virtual interfaces etc.

Yeah, I'm not sure how to do that yet, maybe have exported functions.
Currently, d80211 can also create virtual interfaces via sysfs so...

johannes