Re: [NET_SCHED]: Add mask support to fwmark classifier

[jamal <hadi@cyberus.ca>]

On Fri, 2006-25-08 at 14:02 +0200, Patrick McHardy wrote:
> Thomas Graf wrote:
> > * Patrick McHardy <kaber@trash.net> 2006-08-25 12:29
> > 
> >>The problem is that in order to avoid walking through all filters
> >>contained in one instance, we need to mask the value before the
> >>lookup. This means all filters share the same mask, which is
> >>taken from the first filter created and stored in the filter head.
> >>The user interface however always refers to a single filter,
> >>not the head, so it can't be changed afterwards unless we just
> >>overwrite it whenever a new filter is installed. Both is not
> >>really perfect. The current patch doesn't allow to change the
> >>mark and enforces that all filters use the same one, which I think
> >>is better than allowing inconsistent configurations.
> > 
> > 
> > The other option gets down to replacing the hash table with a
> > list and that's not an option in my opinion. This looks very
> > good to me.
> 

This doesnt obsolete my previous ack, but:

Another approach could have been to add the mask as part of the hashing.
and you add the new hash field not in the head rather in the filter. At
runtime, you hash - walk the bucket and compare the mask as well as the
index.

The above could be a future improvement. 

cheers,
jamal