netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Chan" <mchan@broadcom.com>
To: "Marc Bevand" <m.bevand@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH -rt DO NOT APPLY] Fix for tg3 networking lockup
Date: Fri, 25 Aug 2006 15:55:33 -0700	[thread overview]
Message-ID: <1156546533.5021.10.camel@rh4> (raw)
In-Reply-To: <loom.20060825T235849-675@post.gmane.org>

On Fri, 2006-08-25 at 22:33 +0000, Marc Bevand wrote:

> Still, it would be great if ASF could be disabled, because I have
> noticed that when ASF is enabled, the tg3 driver automatically disables
> TSO (TCP Segmentation Offloading). Here is a dmesg output from a server
> where I am seeing that behavior:
> 
>   eth0: Tigon3 [partno(BCM95704A6) rev 2100 PHY(5704)] (PCIX:133MHz:64-bit) \
>     10/100/1000BaseT Ethernet 00:30:48:59:c4:94
>   eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[1] Split[0] WireSpeed[1] TSOcap[0]
>   [...]
>   eth1: Tigon3 [partno(BCM95704A6) rev 2100 PHY(5704)] (PCIX:133MHz:64-bit) \
>     10/100/1000BaseT Ethernet 00:30:48:59:c4:95
>   eth1: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] Split[0] WireSpeed[1] TSOcap[1]
> 
> Both interfaces are fundamentally TSO-capable, but since ASF is enabled
> on eth0, tg3 disables TSO on this interface. Of course at this point it
> is not even possible to use ethtool to re-enable it because the driver
> considers eth0 as not TSO-capable at all.
> 

The reason is that TSO on 5704 and older chips is done by firmware.  ASF
is also implemented by firmware.  If ASF is enabled, there is no room to
do TSO and ASF at the same time.

Firmware-based TSO is actually slower than no TSO.  The only benefit is
a little better CPU utilization.

On the newer chips, TSO is done by hardware which solves both the ASF
and throughput problems.


  reply	other threads:[~2006-08-25 22:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060803075704.GC27835@thunk.org>
2006-08-03 10:00 ` [PATCH -rt DO NOT APPLY] Fix for tg3 networking lockup Herbert Xu
2006-08-03 16:32   ` Theodore Tso
2006-08-03 16:46     ` Daniel Walker
2006-08-03 17:17       ` Theodore Tso
2006-08-03 21:45         ` David Miller
2006-08-03 16:49     ` Randy.Dunlap
2006-08-03 17:04       ` Alistair John Strachan
2006-08-03 21:43         ` David Miller
2006-08-03 17:28       ` Theodore Tso
2006-08-03 18:36   ` Michael Chan
2006-08-03 20:17     ` Theodore Tso
2006-08-03 21:48       ` David Miller
2006-08-03 23:28         ` Michael Chan
2006-08-03 23:43           ` David Miller
2006-08-04  0:07             ` Theodore Tso
2006-08-04  0:20               ` David Miller
2006-08-04  0:25               ` Arjan van de Ven
2006-08-04  3:23           ` Theodore Tso
2006-08-04  3:45             ` Michael Chan
2006-08-05 20:26               ` Theodore Tso
2006-08-08  6:36                 ` Michael Chan
2006-08-25 22:33                   ` Marc Bevand
2006-08-25 22:55                     ` Michael Chan [this message]
2006-08-25 23:48                       ` Marc Bevand
2006-08-26  0:01                         ` Michael Chan
2006-08-03 23:53         ` Theodore Tso
2006-08-03 23:56           ` David Miller
2006-08-03 23:59             ` Herbert Xu
2006-08-04  0:01               ` David Miller
2006-08-04  0:16                 ` Michael Chan
2006-08-04  0:03             ` Daniel Walker
2006-08-07  5:34           ` Steven Rostedt
2006-08-07  6:18             ` David Miller
2006-08-08 12:24               ` Steven Rostedt
2006-08-08 13:13                 ` Steven Rostedt
2006-08-08 22:00                 ` David Miller
2006-08-08 22:27                   ` Steven Rostedt
2006-08-09 11:29                     ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1156546533.5021.10.camel@rh4 \
    --to=mchan@broadcom.com \
    --cc=m.bevand@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).