From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jkm@devicescape.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Jiri Benc <jbenc@suse.cz>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] d80211: use list_for_each_entry{,_safe}
Date: Thu, 31 Aug 2006 08:58:50 +0200 [thread overview]
Message-ID: <1157007530.3065.0.camel@ux156> (raw)
In-Reply-To: <20060830154322.GA18041@instant802.com>
On Wed, 2006-08-30 at 08:43 -0700, Jouni Malinen wrote:
> Could you please separate cleanup parts (list_for_each changes) from
> functional changes (adding locking) to make it easier to review the
> patch?
Yeah, I guess I should do that.
> I would prefer not to hold spinlocks when calling registered callbacks
> from the hardware driver. At minimum, this would need to be documented
> very clearly to make sure that whoever is writing low-level drivers
> would be aware of this. In general, it would just be simpler if this can
> be avoided altogether.
You don't really have a choice here. The spinlock is the only thing that
protects the list... Not holding it is, umm, a bug :)
johannes
next prev parent reply other threads:[~2006-08-31 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 8:43 [PATCH] d80211: use list_for_each_entry{,_safe} Johannes Berg
2006-08-30 15:43 ` Jouni Malinen
2006-08-31 6:58 ` Johannes Berg [this message]
2006-09-21 17:48 ` Jiri Benc
2006-09-22 9:04 ` Johannes Berg
2006-09-22 12:00 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157007530.3065.0.camel@ux156 \
--to=johannes@sipsolutions.net \
--cc=jbenc@suse.cz \
--cc=jkm@devicescape.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).