Netdev List
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RFC][IPSEC]: tunnel mode processing
Date: Fri, 01 Sep 2006 08:56:18 -0400	[thread overview]
Message-ID: <1157115379.5057.84.camel@jzny2> (raw)
In-Reply-To: <20060901122255.GA18143@gondor.apana.org.au>

On Fri, 2006-01-09 at 22:22 +1000, Herbert Xu wrote:

> Right, you're testing the receiver side.  

both in/out sides (on the receiver); i just count and drop all packets
coming back to the sender (the pktgenerator)

> In that case I suggest that
> you replicate the IPsec transport mode logic in the generator.  

Tunnel mode you mean, i think.

> Just
> as pktgen doesn't use net/ipv4/udp.c to generate UDP traffic, it doesn't
> really need to use xfrm4_output.c to generate IPsec traffic.
> 

IPsec is slightly different since i need to use state in the core. i.e
it is stateful. Nothing that pktgen does today has such requirements.

> You can still call down to esp4.c through the type pointer of course.

Thats one idea i havent thought of. 

i.e the code would look like:
-----
        if (mode == tunnel) 
		err = mytunneloutput (x, skb);
	else 
        	err = x->mode->output(x, skb);
        if (err)
                goto error;
        err = x->type->output(x, skb);
--

This is what you are suggesting?
I am probably better off going back to creating a dummy dst with just
those two fields when in  tunnel mode;->

cheers,
jamal


  reply	other threads:[~2006-09-01 12:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-01  0:55 [RFC][IPSEC]: tunnel mode processing jamal
2006-09-01  4:07 ` Herbert Xu
2006-09-01 12:17   ` jamal
2006-09-01 12:22     ` Herbert Xu
2006-09-01 12:56       ` jamal [this message]
2006-09-01 13:04         ` Herbert Xu
2006-09-01 13:12           ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1157115379.5057.84.camel@jzny2 \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox