public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [IPSEC]: searching  SAD without assumming L3 details
Date: Wed, 06 Sep 2006 07:20:39 -0400	[thread overview]
Message-ID: <1157541639.5039.28.camel@jzny2> (raw)
In-Reply-To: <20060905233823.GA9217@gondor.apana.org.au>

On Wed, 2006-06-09 at 09:38 +1000, Herbert Xu wrote:
> On Sat, Sep 02, 2006 at 09:43:02AM -0400, jamal wrote:
> >
> > Allow for searching the SAD from external data path points without
> > assumming L3 details. The only customer of this exposure currently
> > is pktgen.
> 
> Any reason why xfrm_state_find can't be used? 

xfrm_state_find is overkill (if you compare the two functionalities). 

> It doesn't look right
> to add generic code that's only used by pktgen.

The alternative would require heavy mods to xfrm_state_find to do the
minimal needed (a lot more than what i was asking for in mode output). I
could move the function to outside of xfrm_state.c but that would
require a few exports for it to use which looks less fair to me ;-> 

cheers,
jamal


  reply	other threads:[~2006-09-06 11:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-02 13:43 [IPSEC]: searching SAD without assumming L3 details jamal
2006-09-02 15:04 ` James Morris
2006-09-02 17:16   ` jamal
2006-09-02 18:11     ` jamal
2006-09-02 19:24     ` James Morris
2006-09-05 23:38 ` Herbert Xu
2006-09-06 11:20   ` jamal [this message]
2006-09-06 11:26     ` Herbert Xu
2006-09-06 12:14       ` jamal
2006-09-06 12:30         ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1157541639.5039.28.camel@jzny2 \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox