From: "Darren Jenkins\\" <darrenrjenkins@gmail.com>
To: kernel Janitors <kernel-janitors@lists.osdl.org>
Cc: mb@bu3sch.de, NetDev <netdev@vger.kernel.org>
Subject: [KJ][Patch] remove dead code in bcm43xx_sysfs.c
Date: Thu, 07 Sep 2006 17:27:39 +1000 [thread overview]
Message-ID: <1157614059.22555.19.camel@localhost.localdomain> (raw)
G'day people,
Coverity CID 1161
This is probably fixed in some external tree, but in case it isn't, here is a patch
Compile tested with allyesconfig
Remove some dead code from bcm43xx_sysfs.c in 2.6.18-rc6
Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
--- drivers/net/wireless/bcm43xx/bcm43xx_sysfs.c.orig 2006-09-07 15:40:33.000000000 +1000
+++ drivers/net/wireless/bcm43xx/bcm43xx_sysfs.c 2006-09-07 15:42:02.000000000 +1000
@@ -276,7 +276,6 @@ static ssize_t bcm43xx_attr_preamble_sto
{
struct bcm43xx_private *bcm = dev_to_bcm(dev);
unsigned long flags;
- int err;
int value;
if (!capable(CAP_NET_ADMIN))
@@ -289,10 +288,9 @@ static ssize_t bcm43xx_attr_preamble_sto
bcm->short_preamble = !!value;
- err = 0;
bcm43xx_unlock_irqsafe(bcm, flags);
- return err ? err : count;
+ return count;
}
static DEVICE_ATTR(shortpreamble, 0644,
next reply other threads:[~2006-09-07 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 7:27 Darren Jenkins\ [this message]
2006-09-07 7:33 ` [KJ][Patch] remove dead code in bcm43xx_sysfs.c Darren Jenkins\
2006-09-07 10:07 ` [KJ][Patch][update] " Darren Jenkins\
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157614059.22555.19.camel@localhost.localdomain \
--to=darrenrjenkins@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).