From: "Michael Chan" <mchan@broadcom.com>
To: "Segher Boessenkool" <segher@kernel.crashing.org>
Cc: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Linux Kernel list" <linux-kernel@vger.kernel.org>
Subject: Re: TG3 data corruption (TSO ?)
Date: Fri, 08 Sep 2006 12:54:16 -0700 [thread overview]
Message-ID: <1157745256.5344.8.camel@rh4> (raw)
In-Reply-To: <9EAEC3B2-260E-444E-BCA1-3C9806340F65@kernel.crashing.org>
On Fri, 2006-09-08 at 21:29 +0200, Segher Boessenkool wrote:
> I've got a patch that seems so solve the problem, it needs more testing
> though (maybe Ben can do this :-) ). The problem is that there should
> be quite a few wmb()'s in the code that are just not there; adding some
> to tg3_set_txd() seems to fix the immediate problem but more is needed
> (and I don't see why those should be needed, unless tg3_set_txd() is
> updating a life ring entry in place or something like that).
>
> More testing is needed, but the problem is definitely the lack of memory
> ordering.
>
Oh, we know about this. The powerpc writel() used to have memory
barriers in 2.4 kernels but not any more in 2.6 kernels. Red Hat's
version of tg3 has extra wmb()'s to fix this problem. David doesn't
think that the upstream version of tg3 should have these wmb()'s, and
the problem should instead be fixed in powerpc's writel().
next prev parent reply other threads:[~2006-09-08 19:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1157704257.31071.68.camel@localhost.localdomain>
2006-09-08 15:49 ` TG3 data corruption (TSO ?) Michael Chan
2006-09-08 19:29 ` Segher Boessenkool
2006-09-08 19:54 ` Michael Chan [this message]
2006-09-08 21:46 ` Benjamin Herrenschmidt
2006-09-08 22:22 ` Michael Chan
2006-09-09 9:22 ` David Miller
2006-09-09 22:36 ` Benjamin Herrenschmidt
2006-09-10 0:38 ` Alan Cox
2006-09-10 1:17 ` Benjamin Herrenschmidt
2006-09-11 4:53 ` Benjamin Herrenschmidt
2006-09-11 5:18 ` Michael Chan
2006-09-11 5:25 ` Benjamin Herrenschmidt
2006-09-11 5:33 ` Michael Chan
2006-09-11 5:52 ` Benjamin Herrenschmidt
2006-09-11 8:20 ` Benjamin Herrenschmidt
2006-09-11 13:54 ` Segher Boessenkool
2006-09-11 16:08 ` Michael Chan
2006-09-08 21:41 ` Benjamin Herrenschmidt
2006-09-08 22:07 ` Michael Chan
2006-09-08 22:25 ` Benjamin Herrenschmidt
2006-09-08 22:40 ` Michael Chan
2006-09-08 22:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157745256.5344.8.camel@rh4 \
--to=mchan@broadcom.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).