From: "Michael Chan" <mchan@broadcom.com>
To: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>
Cc: "Segher Boessenkool" <segher@kernel.crashing.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Linux Kernel list" <linux-kernel@vger.kernel.org>
Subject: Re: TG3 data corruption (TSO ?)
Date: Mon, 11 Sep 2006 09:08:51 -0700 [thread overview]
Message-ID: <1157990931.5436.5.camel@rh4> (raw)
In-Reply-To: <1157953925.31071.413.camel@localhost.localdomain>
On Mon, 2006-09-11 at 15:52 +1000, Benjamin Herrenschmidt wrote:
> Looks like adding a sync to writel does fix it though... I'm trying to
> figure out which specific writel in the driver makes a difference. I'll
> then look into slicing those tcpdumps.
During runtime in the fast path, the only writel()'s we do in tg3 are to
the tx mbox, rx_mbox, and the interrupt mbox. The interrupt mbox
shouldn't matter that much since it has no dependencies on other memory
writes before it.
next prev parent reply other threads:[~2006-09-11 16:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1157704257.31071.68.camel@localhost.localdomain>
2006-09-08 15:49 ` TG3 data corruption (TSO ?) Michael Chan
2006-09-08 19:29 ` Segher Boessenkool
2006-09-08 19:54 ` Michael Chan
2006-09-08 21:46 ` Benjamin Herrenschmidt
2006-09-08 22:22 ` Michael Chan
2006-09-09 9:22 ` David Miller
2006-09-09 22:36 ` Benjamin Herrenschmidt
2006-09-10 0:38 ` Alan Cox
2006-09-10 1:17 ` Benjamin Herrenschmidt
2006-09-11 4:53 ` Benjamin Herrenschmidt
2006-09-11 5:18 ` Michael Chan
2006-09-11 5:25 ` Benjamin Herrenschmidt
2006-09-11 5:33 ` Michael Chan
2006-09-11 5:52 ` Benjamin Herrenschmidt
2006-09-11 8:20 ` Benjamin Herrenschmidt
2006-09-11 13:54 ` Segher Boessenkool
2006-09-11 16:08 ` Michael Chan [this message]
2006-09-08 21:41 ` Benjamin Herrenschmidt
2006-09-08 22:07 ` Michael Chan
2006-09-08 22:25 ` Benjamin Herrenschmidt
2006-09-08 22:40 ` Michael Chan
2006-09-08 22:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157990931.5436.5.camel@rh4 \
--to=mchan@broadcom.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).