From: Michael Neuling <mikey@neuling.org>
To: Jeff Mahoney <jeffm@suse.com>, Olaf Hering <ohering@suse.com>,
Jiri Slaby <jslaby@suse.cz>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Subject: [PATCH] net: Fix ehea warning when built in
Date: Thu, 21 Nov 2013 15:36:49 +1100 [thread overview]
Message-ID: <11586.1385008609@ale.ozlabs.ibm.com> (raw)
In:
commit 7a3a62128388a6af771e99df8628ddee2e8be7ca
Author: Olaf Hering <ohering@suse.com>
drivers/net/ethernet/ibm/ehea/ehea_main.c: add alias entry for portN properties
We added ehea_module_device_table. Unfortunately we only use this when
building as a module so we get the following warning when built in, like
in pseries_defconfig:
drivers/net/ethernet/ibm/ehea/ehea_main.c:105:1: warning: 'ehea_module_device_table' defined but not used [-Wunused-variable]
This wraps ehea_module_device_table with #if MODULE.
Signed-off-by: Michael Neuling <mikey@neuling.org>
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index 2d1c6bd..a17a1d1 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
@@ -102,6 +102,7 @@ static int ehea_probe_adapter(struct platform_device *dev);
static int ehea_remove(struct platform_device *dev);
+#ifdef MODULE
static struct of_device_id ehea_module_device_table[] = {
{
.name = "lhea",
@@ -114,6 +115,7 @@ static struct of_device_id ehea_module_device_table[] = {
{},
};
MODULE_DEVICE_TABLE(of, ehea_module_device_table);
+#endif
static struct of_device_id ehea_device_table[] = {
{
next reply other threads:[~2013-11-21 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 4:36 Michael Neuling [this message]
2013-11-21 18:07 ` [PATCH] net: Fix ehea warning when built in David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11586.1385008609@ale.ozlabs.ibm.com \
--to=mikey@neuling.org \
--cc=cascardo@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jeffm@suse.com \
--cc=jslaby@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=ohering@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).