netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Williams <dcbw@redhat.com>
Cc: mabbas <mabbas@linux.intel.com>, Jiri Benc <jbenc@suse.cz>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status
Date: Fri, 22 Sep 2006 10:32:17 +0200	[thread overview]
Message-ID: <1158913937.5368.10.camel@ux156> (raw)
In-Reply-To: <1158870634.5769.21.camel@localhost.localdomain>

On Thu, 2006-09-21 at 16:30 -0400, Dan Williams wrote:

> That's kind a hole in the WE API.  In this case, I think, SIOCGIWAP
> should always return the BSSID of the current association, or none if
> there is no association.

I was never sure if it was a hole or just a lack of clearly defined
semantics (duh, I should probably look at the iwconfig code......)

> Doing an iwconfig ap xx:xx:xx:xx:xx:xx should make the driver internally
> locked to that BSSID, such that until you clear that lock, SIOCGIWAP
> should only show either that BSSID or 00:00:00:00:00:00.  SIOCGIWAP
> should not return a valid BSSID when there is no association.
> 
> Hopefully nl80211 can fix this omission in WE.

I think I have addressed this already.

+       /* set access point BSSID for userspace roaming */
+       NL80211_CMD_SET_BSSID,
...
+
+       /* BSSID to associate to, only used when roaming control
+        * is in userspace */
+       NL80211_ATTR_BSSID,
+
...

+       /* get current association information, if not associated then
+        * the BSSID attribute is not present in response */
+       NL80211_CMD_GET_ASSOCIATION,

as well as in the compatibility document:

+SIOCSIWAP
+  -> if bssid is all-ones: set roaming to kernel, reassociate
+  -> if bssid is all-zeroes: set roaming to kernel
+  -> otherwise: set roaming to userspace, set bssid
+
+SIOCGIWAP
+  -> get association parameters and fill return bssid appropriately


I think that should do what you need, no?

johannes

  parent reply	other threads:[~2006-09-22  8:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-28 20:49 [PATCH 5/7] d80211: indicate if unassociate/radio off status mabbas
2006-08-28 21:17 ` Michael Wu
2006-08-29 17:55   ` Jouni Malinen
2006-08-29 22:28     ` Mohamed Abbas
2006-08-29 22:50       ` Michael Wu
2006-08-29 23:01         ` Michael Wu
2006-08-30 13:41           ` Dan Williams
2006-08-30 17:22             ` Michael Wu
2006-09-21 17:01 ` Jiri Benc
2006-09-21 19:03   ` Dan Williams
2006-09-21 19:47     ` mabbas
2006-09-21 20:30       ` Dan Williams
2006-09-21 20:39         ` mabbas
2006-09-21 22:38           ` Jiri Benc
2006-09-21 22:55             ` Jean Tourrilhes
2006-09-22  0:42               ` Jouni Malinen
2006-09-22  0:57                 ` Jean Tourrilhes
2006-09-22 22:29                   ` [d80211 patch 1/1] setting bss freq and phymode using rx_status mabbas
2006-09-25 16:16                     ` Jiri Benc
2006-09-25 17:15                       ` mabbas
2006-09-27 15:34                         ` Jiri Benc
2006-09-22  8:32         ` Johannes Berg [this message]
2006-09-22 14:05           ` [PATCH 5/7] d80211: indicate if unassociate/radio off status Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1158913937.5368.10.camel@ux156 \
    --to=johannes@sipsolutions.net \
    --cc=dcbw@redhat.com \
    --cc=jbenc@suse.cz \
    --cc=mabbas@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).