From: mostrows@earthlink.net
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
ppp-bugs@dp.samba.org
Cc: Michal Ostrowski <mostrows@earthlink.net>
Subject: [PATCH] Advertise PPPoE MTU / avoid memory leak.
Date: Sat, 23 Sep 2006 12:30:23 -0500 [thread overview]
Message-ID: <115903262344-git-send-email-mostrows@earthlink.net> (raw)
PPPoE must advertise the underlying device's MTU via the ppp channel
descriptor structure, as multilink functionality depends on it.
__pppoe_xmit must free any skb it allocates if there is an error
submitting the skb downstream.
Signed-off-by: Michal Ostrowski <mostrows@earthlink.net>
---
drivers/net/pppoe.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c
index 475dc93..b4dc516 100644
--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -600,6 +600,7 @@ static int pppoe_connect(struct socket *
po->chan.hdrlen = (sizeof(struct pppoe_hdr) +
dev->hard_header_len);
+ po->chan.mtu = dev->mtu - sizeof(struct pppoe_hdr);
po->chan.private = sk;
po->chan.ops = &pppoe_chan_ops;
@@ -831,7 +832,7 @@ static int __pppoe_xmit(struct sock *sk,
struct pppoe_hdr *ph;
int headroom = skb_headroom(skb);
int data_len = skb->len;
- struct sk_buff *skb2;
+ struct sk_buff *skb2 = NULL;
if (sock_flag(sk, SOCK_DEAD) || !(sk->sk_state & PPPOX_CONNECTED))
goto abort;
@@ -887,6 +888,8 @@ static int __pppoe_xmit(struct sock *sk,
return 1;
abort:
+ if (skb2)
+ kfree_skb(skb2);
return 0;
}
--
1.4.1.1
next reply other threads:[~2006-09-23 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 17:30 mostrows [this message]
2006-09-23 21:56 ` [PATCH] Advertise PPPoE MTU / avoid memory leak David Miller
2006-09-24 12:29 ` Michal Ostrowski
2006-09-25 1:41 ` David Miller
2006-09-25 18:16 ` Michal Ostrowski
2006-09-26 6:32 ` Pekka Savola
2006-09-27 13:53 ` Michal Ostrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115903262344-git-send-email-mostrows@earthlink.net \
--to=mostrows@earthlink.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ppp-bugs@dp.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).