From: Johannes Berg <johannes@sipsolutions.net>
To: Daniel Drake <dsd@gentoo.org>
Cc: netdev@vger.kernel.org, mb@bu3sch.de, yi.zhu@intel.com,
jketreno@linux.intel.com
Subject: Re: [PATCH,RFT] ieee80211: Move IV/ICV stripping into ieee80211_rx
Date: Mon, 25 Sep 2006 10:58:03 +0200 [thread overview]
Message-ID: <1159174683.4509.11.camel@ux156> (raw)
In-Reply-To: <20060924224317.D294E7B40A0@zog.reactivated.net>
On Sun, 2006-09-24 at 23:43 +0100, Daniel Drake wrote:
> This patch adds a host_strip_iv_icv flag to ieee80211 which indicates that
> ieee80211_rx should strip the IV/ICV/other security features from the payload.
> This saves on some memmove() calls in the driver and seems like something that
> belongs in the stack as it can be used by bcm43xx, ipw2200, and zd1211rw
>
> I need someone to test this on ipw2200 as I don't have the hardware.
> As hardware decryption is disabled in bcm43xx I'm guessing that the code doesn't
> work yet? Either way I have added in the necessary changes should it be
> enabled in the future.
>
> This patch also adds some sensible variable reuse (idx vs keyidx) in
> ieee80211_rx
>
> Signed-off-by: Daniel Drake <dsd@gentoo.org>
Looks good to me. As for bcm43xx, yes, the hw crypto isn't working
perfectly yet. There's actually an option to enable it though, so the
patch might need some changes.
Acked-by: Johannes Berg <johannes@sipsolutions.net>
johannes
next prev parent reply other threads:[~2006-09-25 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-24 22:43 [PATCH,RFT] ieee80211: Move IV/ICV stripping into ieee80211_rx Daniel Drake
2006-09-25 8:58 ` Johannes Berg [this message]
2006-09-25 14:50 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159174683.4509.11.camel@ux156 \
--to=johannes@sipsolutions.net \
--cc=dsd@gentoo.org \
--cc=jketreno@linux.intel.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).