netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Chan" <mchan@broadcom.com>
To: "Brice Goglin" <brice@myri.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present
Date: Sat, 30 Sep 2006 11:09:46 -0700	[thread overview]
Message-ID: <1159639786.3741.52.camel@rh4> (raw)
In-Reply-To: <451E434E.5040500@myri.com>

On Sat, 2006-09-30 at 12:13 +0200, Brice Goglin wrote:

> What if the machine has such a bridge and board, but the board is not
> actually located somewhere behind the bridge? I would rather walk the
> PCI hierarchy from the board to the top and check whether we find a
> AMD8132. Probably something like:
> 

I have considered that.  I have PCI walking code like in tg3 to
determine if certain tg3 devices are behind some ICH or ServerWorks EPB
bridges.  The workaround needed in those cases have big impact on
performance and therefore it is important to determine exactly when to
apply those workarounds.

Here in this case, since the difference in performance between MSI and
INTA is very minor and almost negligible in a lot of cases, I decided to
keep it simple and just check for the presence of the 8132.


      reply	other threads:[~2006-09-30 18:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-29 21:07 [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present Michael Chan
2006-09-29 21:28 ` Jeff Garzik
2006-09-29 21:39   ` Michael Chan
2006-09-29 22:49     ` David Miller
2006-09-29 23:00       ` Jeff Garzik
2006-09-29 23:08         ` David Miller
2006-09-29 23:15           ` Jeff Garzik
2006-09-29 23:27             ` Michael Chan
2006-09-29 23:29             ` David Miller
2006-09-30  0:38               ` Jeff Garzik
2006-09-30  1:22                 ` David Miller
2006-09-29 23:46           ` Rick Jones
2006-09-30  0:16         ` Roland Dreier
2006-09-30  0:07 ` David Miller
2006-09-30 10:13 ` Brice Goglin
2006-09-30 18:09   ` Michael Chan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1159639786.3741.52.camel@rh4 \
    --to=mchan@broadcom.com \
    --cc=brice@myri.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).