From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Matthew Wilcox <matthew@wil.cx>
Cc: chas3@users.sourceforge.net, Jeff Garzik <jeff@garzik.org>,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, kkeil@suse.de, kai.germaschewski@gmx.de,
isdn4linux@listserv.isdn4linux.de, mac@melware.de,
markus.lidel@shadowconnect.com, samuel@sortiz.org,
Neela.Kolli@engenio.com, linux-scsi@vger.kernel.org,
Greg KH <greg@kroah.com>,
thomas@winischhofer.net, ak@suse.de
Subject: Re: [PATCH] Introduce BROKEN_ON_64BIT facility
Date: Mon, 02 Oct 2006 17:21:11 +0100 [thread overview]
Message-ID: <1159806071.8907.28.camel@localhost.localdomain> (raw)
In-Reply-To: <20061002151853.GK16272@parisc-linux.org>
> (whitespace damaged; more for comment than for application).
>
> > - if ((u32)skb->data & 3) {
> > + if ((unsigned long)skb->data & 3) {
>
> I suppose it quietens a compiler warning. Doesn't actually fix a bug
> though.
Right but it does no harm casting it to either so its worth cleaning up.
prev parent reply other threads:[~2006-10-02 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-02 4:55 [PATCH] Introduce BROKEN_ON_64BIT facility Jeff Garzik
2006-10-02 9:51 ` Andi Kleen
2006-10-02 9:54 ` Jeff Garzik
2006-10-02 14:19 ` Markus Lidel
2006-10-02 13:03 ` Alan Cox
2006-10-02 13:52 ` chas williams - CONTRACTOR
2006-10-02 15:12 ` Alan Cox
2006-10-02 15:18 ` Matthew Wilcox
2006-10-02 16:21 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159806071.8907.28.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Neela.Kolli@engenio.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=chas3@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=jeff@garzik.org \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mac@melware.de \
--cc=markus.lidel@shadowconnect.com \
--cc=matthew@wil.cx \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).