From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH net-next 0/2] bpf/tracing: allow user space to query prog array on the same tp Date: Wed, 29 Nov 2017 21:32:59 -0800 Message-ID: <115a2167-9921-a45c-3877-a81953f9ddaf@fb.com> References: <20171129072036.467246-1-yhs@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: To: Yonghong Song , , , , , Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:51186 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802AbdK3Fdx (ORCPT ); Thu, 30 Nov 2017 00:33:53 -0500 In-Reply-To: <20171129072036.467246-1-yhs@fb.com> Sender: netdev-owner@vger.kernel.org List-ID: On 11/28/17 11:20 PM, Yonghong Song wrote: > Commit e87c6bc3852b ("bpf: permit multiple bpf attachments > for a single perf event") added support to attach multiple > bpf programs to a single perf event. Given a perf event > (kprobe, uprobe, or kernel tracepoint), the perf ioctl interface > is used to query bpf programs attached to the same trace event. > The same ioctl interface is also used to attach bpf program. > Patch #1 had the core implementation and patch #2 added > a test case in tools bpf selftests suite. We actually had an implementation of the same tracepoint+bpf introspection via BPF_PROG_QUERY command that we use for cgroup+bpf, but it looks cleaner to use ioctl() style of api here, since attach to tracepoint/kuprobe is also done via ioctl. For the set: Acked-by: Alexei Starovoitov The patch touches 3 lines in events/core.c but most likely it won't conflict with anything in tip, so we plan to have this set in bpf-next.git -> net-next.git only. Thanks