From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Huang Subject: [PATCH 5/5] Solve host error problem in low performance embedded system when continune down and up. Date: Sat, 14 Oct 2006 15:57:40 -0400 Message-ID: <1160855860.2266.9.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from msr41.hinet.net ([168.95.4.141]:11515 "EHLO msr41.hinet.net") by vger.kernel.org with ESMTP id S1161015AbWJNIN0 (ORCPT ); Sat, 14 Oct 2006 04:13:26 -0400 To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@osdl.org, jgarzik@pobox.com, jesse@icplus.com.tw Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jesse Huang Change Logs: Solve host error problem in low performance embedded system when continune down and up. It will cause IP100A DMA TargetAbort. So we need more safe process to up and down IP100A with wait hardware completely stop and software cur_tx/ dirty_tx/cur_task/last_tx be clear. Signed-off-by: Jesse Huang --- drivers/net/sundance.c | 26 +++++++++++++++++++++++--- 1 files changed, 23 insertions(+), 3 deletions(-) c06c70e20a85facd640528ca66e0b579fc3ee745 diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c index 14b4933..b4a6010 100755 --- a/drivers/net/sundance.c +++ b/drivers/net/sundance.c @@ -1643,6 +1643,14 @@ static int netdev_close(struct net_devic struct sk_buff *skb; int i; + /* Wait and kill tasklet */ + tasklet_kill(&np->rx_tasklet); + tasklet_kill(&np->tx_tasklet); + np->cur_tx = 0; + np->dirty_tx = 0; + np->cur_task = 0; + np->last_tx = 0; + netif_stop_queue(dev); if (netif_msg_ifdown(np)) { @@ -1663,9 +1671,20 @@ static int netdev_close(struct net_devic /* Stop the chip's Tx and Rx processes. */ iowrite16(TxDisable | RxDisable | StatsDisable, ioaddr + MACCtrl1); - /* Wait and kill tasklet */ - tasklet_kill(&np->rx_tasklet); - tasklet_kill(&np->tx_tasklet); + for (i = 2000; i > 0; i--) { + if ((ioread32(ioaddr + DMACtrl) &0xC000) == 0) + break; + mdelay(1); + } + + iowrite16(GlobalReset | DMAReset | FIFOReset | NetworkReset, ioaddr +ASICCtrl + 2); + + for (i = 2000; i > 0; i--) + { + if ((ioread16(ioaddr + ASICCtrl +2) &ResetBusy) == 0) + break; + mdelay(1); + } #ifdef __i386__ if (netif_msg_hw(np)) { @@ -1703,6 +1722,7 @@ #endif /* __i386__ debugging only */ } } for (i = 0; i < TX_RING_SIZE; i++) { + np->tx_ring[i].next_desc = 0; skb = np->tx_skbuff[i]; if (skb) { pci_unmap_single(np->pci_dev, -- 1.3.GIT