From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Brownell <david-b@pacbell.net>
Cc: matthew@wil.cx, akpm@osdl.org, val_henson@linux.intel.com,
netdev@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
Date: Sun, 15 Oct 2006 15:21:22 +0100 [thread overview]
Message-ID: <1160922082.5732.51.camel@localhost.localdomain> (raw)
In-Reply-To: <20061015070809.978C714552@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
Ar Sul, 2006-10-15 am 00:08 -0700, ysgrifennodd David Brownell:
> Since it's not an error, there should be no such printk ... which
> is exactly how it's coded above.
The underlying bug is that someone marked pci_set_mwi must-check, that's
wrong for most of the drivers that use it. If you remove the must check
annotation from it then the problem and a thousand other spurious
warnings go away.
next prev parent reply other threads:[~2006-10-15 13:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 19:05 [PATCH 1/2] [PCI] Check that MWI bit really did get set Matthew Wilcox
2006-10-06 19:05 ` [PATCH 2/2] [TULIP] Check the return value from pci_set_mwi() Matthew Wilcox
2006-10-06 19:15 ` Jeff Garzik
2006-10-06 19:28 ` Matthew Wilcox
2006-10-06 19:59 ` Jeff Garzik
2006-10-07 5:34 ` Grant Grundler
2006-10-07 14:44 ` Jeff Garzik
2006-10-06 19:16 ` [PATCH 1/2] [PCI] Check that MWI bit really did get set Jeff Garzik
2006-10-14 4:41 ` Andrew Morton
2006-10-14 5:21 ` Greg KH
2006-10-14 14:02 ` Matthew Wilcox
2006-10-14 20:48 ` Andrew Morton
2006-10-15 3:20 ` Matthew Wilcox
2006-10-15 6:53 ` Andrew Morton
2006-10-15 13:54 ` Matthew Wilcox
2006-10-15 17:47 ` Andrew Morton
2006-10-15 7:08 ` [Bulk] " David Brownell
2006-10-15 13:52 ` Matthew Wilcox
2006-10-15 14:21 ` Alan Cox [this message]
2006-10-15 13:57 ` Matthew Wilcox
2006-10-15 17:45 ` Andrew Morton
2006-10-15 19:16 ` David Brownell
2006-10-15 19:34 ` Andrew Morton
2006-10-15 22:45 ` David Brownell
2006-10-15 23:18 ` Andrew Morton
2006-10-16 0:02 ` Alan Cox
2006-10-15 23:44 ` Andrew Morton
2006-10-16 0:44 ` Paul Mackerras
2006-10-16 1:10 ` Andrew Morton
2006-10-16 2:07 ` David Brownell
2006-10-16 10:58 ` Alan Cox
2006-10-16 11:02 ` Alan Cox
2006-10-16 0:16 ` David Brownell
2006-10-16 0:31 ` Andrew Morton
2006-10-16 10:59 ` Alan Cox
2006-10-15 21:52 ` [Bulk] " Alan Cox
2006-10-16 0:00 ` Paul Mackerras
2006-10-16 0:15 ` Andrew Morton
2006-10-16 0:21 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160922082.5732.51.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=netdev@vger.kernel.org \
--cc=val_henson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).