From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] bcm43xx: Drain TX status before starting IRQs Date: Fri, 20 Oct 2006 10:25:53 +1000 Message-ID: <1161303953.10524.81.camel@localhost.localdomain> References: <200610191729.35402.mb@bu3sch.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Larry Finger Return-path: To: Michael Buesch In-Reply-To: <200610191729.35402.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bcm43xx-dev-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: bcm43xx-dev-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, 2006-10-19 at 17:29 +0200, Michael Buesch wrote: > Drain the Microcode TX-status-FIFO before we enable IRQs. > This is required, because the FIFO may still have entries left > from a previous run. Those would immediately fire after enabling > IRQs and would lead to an oops in the DMA TXstatus handling code. > > Signed-off-by: Michael Buesch Great, thanks. Note that I haven't yet hit the bug since I updated the firmware, so it could be a mix of firmware and that problem, though it's not been long enough to be a clear results. In any case, that patch should go in. Cheers, Ben.