From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: Russell Stuart <russell-tcatm@stuart.id.au>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Jesper Dangaard Brouer <hawk@diku.dk>
Subject: Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)
Date: Thu, 19 Oct 2006 20:49:14 -0400 [thread overview]
Message-ID: <1161305354.5034.50.camel@jzny2> (raw)
In-Reply-To: <45378DE3.8080700@trash.net>
On Thu, 2006-19-10 at 16:38 +0200, Patrick McHardy wrote:
> jamal wrote:
> > ACKed-by: Jamal Hadi Salim
> >
> > When Patrick has his patch ready after this goes in we can revisit.
>
> NACK.
>
> I still think this patch shouldn't go in. There's no point in doing the
> same thing twice, and I haven't heard a compelling argument why it has
> to be done in a way that only helps qdiscs using rtabs while ignoring
> statistics and estimators (I even provided a patch to show how to do
> it without these limitations).
The poor guy has been persistent and has some good ideas and we need to
encourage him to stick around. Why dont you help him get the patch in
the shape you think is reasonable? I know you are busy elsewhere and
your patch has been a while since you last promised. I will try to help
as well.
> Besides that:
I will let Russell respond to the critique (As well as the concept of
stats and estimator); Russell please try to be brief and to the point (I
still have to learn that lesson myself ;->).
cheers,
jamal
next prev parent reply other threads:[~2006-10-20 0:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 23:34 [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel) Russell Stuart
2006-10-17 13:07 ` jamal
2006-10-19 3:41 ` David Miller
2006-10-19 14:38 ` Patrick McHardy
2006-10-20 0:49 ` jamal [this message]
2006-10-20 8:54 ` Patrick McHardy
2006-10-23 11:22 ` Russell Stuart
2006-10-23 12:39 ` Patrick McHardy
2006-10-23 21:54 ` Russell Stuart
2006-10-24 16:19 ` Patrick McHardy
2006-10-24 20:00 ` Jesper Dangaard Brouer
2006-10-24 23:46 ` Russell Stuart
2006-11-30 13:07 ` Patrick McHardy
2007-01-17 23:07 ` Russell Stuart
2007-01-18 4:05 ` Patrick McHardy
2007-01-18 6:16 ` Russell Stuart
[not found] ` <45AF5C02.1010005@trash.net>
2007-01-19 3:11 ` Russell Stuart
2007-01-19 12:19 ` Patrick McHardy
2007-01-20 3:25 ` Russell Stuart
2007-01-20 8:47 ` Patrick McHardy
2007-01-21 7:45 ` Russell Stuart
2007-01-24 16:38 ` Patrick McHardy
2007-01-24 22:32 ` Russell Stuart
2007-01-25 0:06 ` Patrick McHardy
2007-01-25 0:55 ` Russell Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161305354.5034.50.camel@jzny2 \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=hawk@diku.dk \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=russell-tcatm@stuart.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).