From: Pavel Roskin <proski@gnu.org>
To: netdev@vger.kernel.org
Cc: hostap@shmoo.com
Subject: [PATCH] hostap_plx: fix CIS verification
Date: Fri, 20 Oct 2006 18:20:15 -0400 [thread overview]
Message-ID: <1161382815.5803.2.camel@dv> (raw)
hostap_plx: fix CIS verification
The record length for numerical manufacturer ID should be at least 4
bytes (two 16-bit words). The code required 5 bytes, which would break
for most (if not all) cards. Reported by ph35sm@free.fr
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
This is an small fix with significant impact.
hostap_plx is currently broken, and this patch fixes it.
Please forward this patch to 2.6.x.y kernels.
drivers/net/wireless/hostap/hostap_plx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/hostap/hostap_plx.c b/drivers/net/wireless/hostap/hostap_plx.c
index 6dfa041..b5b72db 100644
--- a/drivers/net/wireless/hostap/hostap_plx.c
+++ b/drivers/net/wireless/hostap/hostap_plx.c
@@ -391,7 +391,7 @@ #define CIS_MAX_LEN 256
break;
case CISTPL_MANFID:
- if (cis[pos + 1] < 5)
+ if (cis[pos + 1] < 4)
goto cis_error;
manfid1 = cis[pos + 2] + (cis[pos + 3] << 8);
manfid2 = cis[pos + 4] + (cis[pos + 5] << 8);
--
Regards,
Pavel Roskin
next reply other threads:[~2006-10-20 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 22:20 Pavel Roskin [this message]
2006-10-21 1:19 ` [PATCH] hostap_plx: fix CIS verification Jouni Malinen
2006-10-25 0:37 ` John W. Linville
2006-10-25 0:48 ` Pavel Roskin
2006-10-25 1:44 ` Jouni Malinen
2006-10-25 2:12 ` Pavel Roskin
2006-10-25 2:31 ` Jouni Malinen
2006-10-25 2:41 ` [PATCH FIXED] " Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161382815.5803.2.camel@dv \
--to=proski@gnu.org \
--cc=hostap@shmoo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).