From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: netdev@vger.kernel.org, Jiri Benc <jbenc@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>,
Jean Tourrilhes <jt@hpl.hp.com>
Subject: Re: [RFC] [PATCH 1/3] adds iso3166-1 support
Date: Tue, 24 Oct 2006 10:30:17 +0200 [thread overview]
Message-ID: <1161678617.2840.5.camel@ux156> (raw)
In-Reply-To: <43e72e890610231545n389d8a6dy89bb476101953234@mail.gmail.com>
> +static int load_iso3166_1(void) {
> + int r = 0;
> + r |= iso3166_1_add(4, "AF", "AFG",
> + "Afghanistan");
[...]
Why don't you make the table a static array, then you can use ARRAY_SIZE
and get rid of the whole list_head, not have it eat up code size and
mark it as read-only static data.
> +EXPORT_SYMBOL(iso3166_1_list);
Why export the list?
> +EXPORT_SYMBOL(get_iso3166_1_numeric);
> +EXPORT_SYMBOL(get_iso3166_1_alpha2);
> +EXPORT_SYMBOL(get_iso3166_1_alpha3);
> +EXPORT_SYMBOL(iso3166_1_exists);
Also, please put these along with the function.
johannes
next prev parent reply other threads:[~2006-10-24 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 22:45 [RFC] [PATCH 1/3] adds iso3166-1 support Luis R. Rodriguez
2006-10-24 8:30 ` Johannes Berg [this message]
2006-10-24 15:59 ` Luis R. Rodriguez
2006-10-24 16:08 ` Johannes Berg
2006-10-25 15:05 ` Luis R. Rodriguez
2006-10-25 1:44 ` Anand Kumria
2006-10-25 15:09 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161678617.2840.5.camel@ux156 \
--to=johannes@sipsolutions.net \
--cc=jbenc@suse.cz \
--cc=jt@hpl.hp.com \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).