From: Johannes Berg <johannes@sipsolutions.net>
To: Hong Liu <hong.liu@intel.com>
Cc: Jiri Benc <jbenc@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [patch 1/2]d80211: hardware TKIP support for ipw3945
Date: Tue, 24 Oct 2006 10:35:08 +0200 [thread overview]
Message-ID: <1161678908.2840.12.camel@ux156> (raw)
In-Reply-To: <1161678053.7083.7.camel@devlinux-hong>
On Tue, 2006-10-24 at 16:20 +0800, Hong Liu wrote:
> It's really strange bcm43xx only does phase2 mixing in hw. With all the
> code that does phase2 mixing, doing phase1 mixing is very cheap.
Yeah, well, they have the tkip sbox in hw.
> With Jiri's ieee80211_tx_ctrl_common patch, I think we can put the
> rc4key or phase1 key in ieee80211_tx_control with each TX packet.
No, the phase1 key is not dependent on the packet so it should not be
there. It should be set via the regular key setting mechanism, instead
of the TKIP key the driver would be given the phase1 key if required.
johannes
next prev parent reply other threads:[~2006-10-24 8:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 9:19 [patch 1/2]d80211: hardware TKIP support for ipw3945 Hong Liu
2006-10-21 21:10 ` Matthieu CASTET
2006-10-23 12:40 ` Jiri Benc
2006-10-23 12:48 ` Johannes Berg
2006-10-23 12:56 ` Jiri Benc
2006-10-24 8:20 ` Hong Liu
2006-10-24 8:35 ` Johannes Berg [this message]
2006-10-24 8:38 ` Hong Liu
2006-10-24 9:10 ` Johannes Berg
2006-10-24 9:12 ` Johannes Berg
2006-10-25 8:28 ` Hong Liu
2006-10-25 8:50 ` Johannes Berg
2006-11-14 2:22 ` Hong Liu
2006-11-15 16:25 ` Johannes Berg
2006-11-16 9:52 ` Johannes Berg
2006-11-16 17:21 ` Jouni Malinen
2006-11-16 17:38 ` Johannes Berg
2006-11-16 17:40 ` Jouni Malinen
2006-11-16 17:49 ` Johannes Berg
2006-10-23 13:04 ` Stuffed Crust
2006-10-23 15:29 ` David Kimdon
2006-10-23 16:31 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161678908.2840.12.camel@ux156 \
--to=johannes@sipsolutions.net \
--cc=hong.liu@intel.com \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).