From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zang Roy-r61911 Subject: Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support Date: 26 Oct 2006 10:50:26 +0800 Message-ID: <1161831025.20631.1.camel@localhost.localdomain> References: <1157962200.10526.10.camel@localhost.localdomain> <1158051351.14448.97.camel@localhost.localdomain> <4506C789.4050404@pobox.com> <1158749825.7973.9.camel@localhost.localdomain> <45121924.4000200@pobox.com> <1161569363.23698.4.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , netdev , linux-kernel , "Alexandre.Bounine@tundra.com" Return-path: Received: from de01egw02.freescale.net ([192.88.165.103]:47093 "EHLO de01egw02.freescale.net") by vger.kernel.org with ESMTP id S1422825AbWJZCtx (ORCPT ); Wed, 25 Oct 2006 22:49:53 -0400 To: Jeff Garzik In-Reply-To: <1161569363.23698.4.camel@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 2006-10-23 at 10:09, Zang Roy-r61911 wrote: > On Thu, 2006-09-21 at 12:46, Jeff Garzik wrote: > > > you should have a chip structure, that contains two structs (one for > > each interface/port) > > > Jeff, > > I updated the code according to all your feedback and post it here > > http://www.spinics.net/lists/netdev/msg17120.html > > Any comment? > > Roy Jeff How about it? What's your comment? Roy