From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Jiri Benc <jbenc@suse.cz>,
netdev@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>,
John Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>, Hong Liu <hong.liu@intel.com>
Subject: Re: [PATCH 1/6] d80211: change the cookie to be opaque
Date: Fri, 03 Nov 2006 09:42:46 +0100 [thread overview]
Message-ID: <1162543366.2923.3.camel@ux156> (raw)
In-Reply-To: <200611022128.29060.flamingice@sourmilk.net>
On Thu, 2006-11-02 at 21:28 -0500, Michael Wu wrote:
> That's because TX might fail for reasons other than not getting an ACK. I
> can't say I've actually seen this happen, so it might just be something left
> over from tulip that doesn't need to be there now. (or perhaps it only
> happens when there's something really bad going on) However, what's so bad
> about letting drivers update some statistics if it is possible? If you remove
> ieee80211_dev_stats, please provide some other way for drivers to access
> struct net_device_stats.
Well, you were only changing the master netdev's stats, which isn't
really useful because you want to change the device that transmitted the
frame. But you cannot, because you don't have access to it. In general,
the stack should be doing this, so if some other tx errors are possible
maybe we should add a flag to the tx status.
johannes
next prev parent reply other threads:[~2006-11-03 8:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061102223854.692274000@sipsolutions.net>
2006-11-02 23:28 ` [PATCH 0/6] rework d80211 cookie pointer Michael Wu
[not found] ` <20061102230013.960383000@sipsolutions.net>
2006-11-03 0:22 ` [PATCH 1/6] d80211: change the cookie to be opaque Johannes Berg
2006-11-03 0:46 ` Johannes Berg
2006-11-03 4:15 ` John W. Linville
2006-11-03 8:41 ` Johannes Berg
2006-11-05 15:20 ` Ivo van Doorn
2006-11-05 15:24 ` Johannes Berg
2006-11-03 9:21 ` Johannes Berg
2006-11-03 2:28 ` Michael Wu
2006-11-03 8:42 ` Johannes Berg [this message]
2006-11-03 19:04 ` [PATCH 0/6] rework d80211 cookie pointer Michael Wu
2006-11-03 19:08 ` Johannes Berg
2006-11-03 22:14 ` Michael Wu
2006-11-03 23:10 ` Johannes Berg
[not found] ` <20061102230015.186648000@sipsolutions.net>
2006-11-03 21:49 ` [PATCH 3/6] d80211: add a perm_addr hardware property Michael Wu
2006-11-03 23:19 ` Johannes Berg
[not found] ` <20061102230015.555750000@sipsolutions.net>
2006-11-03 22:27 ` [PATCH 4/6] d80211: add a struct device* " Michael Wu
2006-11-03 23:21 ` Johannes Berg
2006-11-03 23:46 ` Johannes Berg
[not found] ` <20061102230016.080591000@sipsolutions.net>
2006-11-03 22:43 ` [PATCH 5/6] d80211: add a ethtool_ops " Michael Wu
2006-11-03 23:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162543366.2923.3.camel@ux156 \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=hong.liu@intel.com \
--cc=ivdoorn@gmail.com \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).