From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] ieee80211softmac: fix verbosity when debug disabled
Date: Mon, 06 Nov 2006 11:54:20 +0100 [thread overview]
Message-ID: <1162810460.2762.21.camel@ux156> (raw)
In-Reply-To: <454CEA2E.mail3QE112KF3@lwfinger.net>
On Sat, 2006-11-04 at 13:29 -0600, Larry Finger wrote:
> SoftMAC contains a number of debug-type messages that continue to print
> even when debugging is turned off. This patch substitutes dprintkl for
> printkl for those lines.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Fine with me.
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> Index: wireless-2.6/net/ieee80211/softmac/ieee80211softmac_auth.c
> ===================================================================
> --- wireless-2.6.orig/net/ieee80211/softmac/ieee80211softmac_auth.c
> +++ wireless-2.6/net/ieee80211/softmac/ieee80211softmac_auth.c
> @@ -158,7 +158,7 @@ ieee80211softmac_auth_resp(struct net_de
> /* Make sure that we've got an auth queue item for this request */
> if(aq == NULL)
> {
> - printkl(KERN_DEBUG PFX "Authentication response received from "MAC_FMT" but no queue item exists.\n", MAC_ARG(auth->header.addr2));
> + dprintkl(KERN_DEBUG PFX "Authentication response received from "MAC_FMT" but no queue item exists.\n", MAC_ARG(auth->header.addr2));
> /* Error #? */
> return -1;
> }
> @@ -166,7 +166,7 @@ ieee80211softmac_auth_resp(struct net_de
> /* Check for out of order authentication */
> if(!net->authenticating)
> {
> - printkl(KERN_DEBUG PFX "Authentication response received from "MAC_FMT" but did not request authentication.\n",MAC_ARG(auth->header.addr2));
> + dprintkl(KERN_DEBUG PFX "Authentication response received from "MAC_FMT" but did not request authentication.\n",MAC_ARG(auth->header.addr2));
> return -1;
> }
>
> @@ -342,7 +342,7 @@ ieee80211softmac_deauth_req(struct ieee8
> /* Make sure the network is authenticated */
> if (!net->authenticated)
> {
> - printkl(KERN_DEBUG PFX "Can't send deauthentication packet, network is not authenticated.\n");
> + dprintkl(KERN_DEBUG PFX "Can't send deauthentication packet, network is not authenticated.\n");
> /* Error okay? */
> return -EPERM;
> }
> @@ -376,7 +376,7 @@ ieee80211softmac_deauth_resp(struct net_
> net = ieee80211softmac_get_network_by_bssid(mac, deauth->header.addr2);
>
> if (net == NULL) {
> - printkl(KERN_DEBUG PFX "Received deauthentication packet from "MAC_FMT", but that network is unknown.\n",
> + dprintkl(KERN_DEBUG PFX "Received deauthentication packet from "MAC_FMT", but that network is unknown.\n",
> MAC_ARG(deauth->header.addr2));
> return 0;
> }
> @@ -384,7 +384,7 @@ ieee80211softmac_deauth_resp(struct net_
> /* Make sure the network is authenticated */
> if(!net->authenticated)
> {
> - printkl(KERN_DEBUG PFX "Can't perform deauthentication, network is not authenticated.\n");
> + dprintkl(KERN_DEBUG PFX "Can't perform deauthentication, network is not authenticated.\n");
> /* Error okay? */
> return -EPERM;
> }
>
prev parent reply other threads:[~2006-11-06 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-04 19:29 [PATCH] ieee80211softmac: fix verbosity when debug disabled Larry Finger
2006-11-06 10:54 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162810460.2762.21.camel@ux156 \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).