netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: netdev@vger.kernel.org
Cc: Jiri Benc <jbenc@suse.cz>,
	"John W. Linville" <linville@tuxdriver.com>,
	Simon Barber <simon@devicescape.com>,
	Jouni Malinen <jkm@devicescape.com>,
	Hong Liu <hong.liu@intel.com>,
	David Kimdon <david.kimdon@devicescape.com>,
	Michael Wu <flamingice@sourmilk.net>,
	Michael Buesch <mbuesch@freenet.de>,
	Ivo van Doorn <ivdoorn@gmail.com>
Subject: [PATCH] d80211: remove calib_int
Date: Sun, 19 Nov 2006 01:04:44 +0100	[thread overview]
Message-ID: <1163894684.15473.8.camel@johannes.berg> (raw)
In-Reply-To: <1163802439.3392.47.camel@johannes.berg>

The calibration interval is far too hardware dependent to be useful as a
generic stack setting and some hardware doesn't even have that parameter.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

---
Again, applies after my other patches.. I think we want this one and
probably some way to have driver-private settings later.

 include/net/d80211.h         |    2 --
 net/d80211/ieee80211.c       |    1 -
 net/d80211/ieee80211_ioctl.c |   10 ----------
 net/d80211/ieee80211_sysfs.c |    2 --
 4 files changed, 15 deletions(-)

--- wireless-dev.orig/include/net/d80211.h	2006-11-19 00:54:57.539520302 +0100
+++ wireless-dev/include/net/d80211.h	2006-11-19 00:55:03.229520302 +0100
@@ -259,8 +259,6 @@ struct ieee80211_conf {
 			  		 *	1 = Ant0,
 					 *	2 = Ant1 */
 
-	int calib_int;			/* hw/radio calibration interval in
-					 * seconds */
         int antenna_def;
         int antenna_mode;
 
--- wireless-dev.orig/net/d80211/ieee80211.c	2006-11-19 00:55:21.929520302 +0100
+++ wireless-dev/net/d80211/ieee80211.c	2006-11-19 00:55:36.679520302 +0100
@@ -4473,7 +4473,6 @@ struct ieee80211_wiphy *ieee80211_alloc_
 	local->fragmentation_threshold = IEEE80211_MAX_FRAG_THRESHOLD;
 	local->short_retry_limit = 7;
 	local->long_retry_limit = 4;
-	local->wiphy.conf.calib_int = 60;
 	local->wiphy.conf.radio_enabled = 1;
 	local->rate_ctrl_num_up = RATE_CONTROL_NUM_UP;
 	local->rate_ctrl_num_down = RATE_CONTROL_NUM_DOWN;
--- wireless-dev.orig/net/d80211/ieee80211_ioctl.c	2006-11-19 00:55:22.049520302 +0100
+++ wireless-dev/net/d80211/ieee80211_ioctl.c	2006-11-19 00:55:49.879520302 +0100
@@ -2480,12 +2480,6 @@ static int ieee80211_ioctl_prism2_param(
 			ret = -EINVAL;
 		break;
 
-	case PRISM2_PARAM_CALIB_INT:
-		local->wiphy.conf.calib_int = value;
-		if (ieee80211_hw_config(local))
-			ret = -EINVAL;
-		break;
-
 	case PRISM2_PARAM_ANTENNA_MODE:
 		local->wiphy.conf.antenna_mode = value;
 		if (ieee80211_hw_config(local))
@@ -2687,10 +2681,6 @@ static int ieee80211_ioctl_get_prism2_pa
 		*param = local->wiphy.conf.antenna_sel;
 		break;
 
-	case PRISM2_PARAM_CALIB_INT:
-		*param = local->wiphy.conf.calib_int;
-		break;
-
 	case PRISM2_PARAM_ANTENNA_MODE:
 		*param = local->wiphy.conf.antenna_mode;
 		break;
--- wireless-dev.orig/net/d80211/ieee80211_sysfs.c	2006-11-19 00:55:22.169520302 +0100
+++ wireless-dev/net/d80211/ieee80211_sysfs.c	2006-11-19 00:55:58.189520302 +0100
@@ -154,7 +154,6 @@ IEEE80211_LOCAL_SHOW(channel, wiphy.conf
 IEEE80211_LOCAL_SHOW(frequency, wiphy.conf.freq, "%d");
 IEEE80211_LOCAL_SHOW(radar_detect, wiphy.conf.radar_detect, "%d");
 IEEE80211_LOCAL_SHOW(antenna_sel, wiphy.conf.antenna_sel, "%d");
-IEEE80211_LOCAL_SHOW(calib_int, wiphy.conf.calib_int, "%d");
 IEEE80211_LOCAL_SHOW(bridge_packets, bridge_packets, "%d");
 IEEE80211_LOCAL_SHOW(key_tx_rx_threshold, key_tx_rx_threshold, "%d");
 IEEE80211_LOCAL_SHOW(rts_threshold, rts_threshold, "%d");
@@ -220,7 +219,6 @@ static struct class_device_attribute iee
 	__ATTR(frequency, S_IRUGO, ieee80211_local_show_frequency, NULL),
 	__ATTR(radar_detect, S_IRUGO, ieee80211_local_show_radar_detect, NULL),
 	__ATTR(antenna_sel, S_IRUGO, ieee80211_local_show_antenna_sel, NULL),
-	__ATTR(calib_int, S_IRUGO, ieee80211_local_show_calib_int, NULL),
 	__ATTR(bridge_packets, S_IRUGO, ieee80211_local_show_bridge_packets, NULL),
 	__ATTR(key_tx_rx_threshold, S_IRUGO, ieee80211_local_show_key_tx_rx_threshold, NULL),
 	__ATTR(rts_threshold, S_IRUGO, ieee80211_local_show_rts_threshold, NULL),



  parent reply	other threads:[~2006-11-19  0:30 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-17 22:27 [PATCH 0/10] d80211: move away from wmaster towards wiphy Johannes Berg
2006-11-17 22:50 ` [PATCH] d80211: remove useless driver name field Johannes Berg
2006-11-20 18:32   ` Jouni Malinen
2006-11-20 18:40     ` Johannes Berg
2006-11-20 22:21       ` Christoph Hellwig
2006-11-20 22:33         ` Johannes Berg
2006-11-20 18:44     ` Michael Wu
2006-11-17 23:24 ` [PATCH 0/10] d80211: move away from wmaster towards wiphy Pavel Roskin
2006-11-18  0:16 ` Johannes Berg
2006-11-18 23:53 ` [PATCH] d80211: remove IEEE80211_CONF_SW_{EN,DE}CRYPT Johannes Berg
2006-11-19 16:16   ` Michael Buesch
2006-11-19  0:04 ` Johannes Berg [this message]
2006-11-19  0:21 ` [PATCH] d80211: fix scan issues with new ops Johannes Berg
2006-11-19 15:56   ` David Kimdon
2006-11-19 16:34     ` Johannes Berg
2006-11-19 16:50       ` Johannes Berg
2006-11-19 16:55       ` David Kimdon
2006-11-19 16:57         ` Johannes Berg
2006-11-19 17:25           ` David Kimdon
2006-11-19 17:54             ` Johannes Berg
2006-11-19 16:15   ` Michael Buesch
2006-11-19 16:35     ` Johannes Berg
2006-11-19 19:18 ` [PATCH 0/13] move d80211 away from netdev towards wiphy Johannes Berg
2006-11-19 19:22   ` [PATCH 1/13] d80211: clean up some stupid list and loop code Johannes Berg
2006-11-20 11:01     ` Jiri Benc
2006-11-20 11:58       ` Johannes Berg
2006-11-20 18:55         ` Johannes Berg
2006-11-19 19:23   ` [PATCH 2/13] d80211: reduce mdev usage Johannes Berg
2006-11-19 19:23   ` [PATCH 3/13] " Johannes Berg
2006-11-19 19:26   ` [PATCH 4/13] d80211: reduce mdev usage, change ieee80211_rx_mgmt Johannes Berg
2006-11-20 12:08     ` Jiri Benc
2006-11-20 12:25       ` Johannes Berg
2006-11-19 19:27   ` [PATCH 5/13] d80211: reduce master ieee80211_ptr deref in scan routines Johannes Berg
2006-11-19 19:28   ` [PATCH 6/13] d80211: change the identifier netdev to ieee80211_hw Johannes Berg
2006-11-20 17:57     ` Jiri Benc
2006-11-20 18:04       ` Johannes Berg
2006-11-20 18:52       ` Johannes Berg
2006-11-20 22:45     ` Johannes Berg
2006-11-21 17:48       ` [PATCH] d80211: use ieee80211_hw.dev Johannes Berg
2006-11-19 19:29   ` [PATCH 7/13] d80211: add a perm_addr hardware property Johannes Berg
2006-11-19 23:20     ` Johannes Berg
2006-11-20 18:54       ` Johannes Berg
2006-11-19 19:29   ` [PATCH 8/13] d80211: introduce IEEE80211_HW_FRAG flag Johannes Berg
2006-11-19 19:30   ` [PATCH 9/13] d80211: remove useless driver name field Johannes Berg
2006-11-19 19:31   ` [PATCH 10/13] bcm43xx: update to new d80211 driver API Johannes Berg
2006-11-19 19:43     ` Michael Buesch
2006-11-19 19:52       ` Johannes Berg
2006-11-19 19:31   ` [PATCH 11/13] d80211: remove IEEE80211_CONF_SW_{EN,DE}CRYPT Johannes Berg
2006-11-19 19:32   ` [PATCH 12/13] d80211: remove calib_int Johannes Berg
2006-11-19 19:33   ` [PATCH 13/13] d80211: fix scan issues with new ops Johannes Berg
2006-11-19 23:32   ` [PATCH 0/13] move d80211 away from netdev towards wiphy Johannes Berg
2006-11-20 19:14     ` Jiri Benc
2006-11-22 19:18       ` [RFC 0/3] more power to cfg80211 Johannes Berg
2006-11-22 19:22         ` [RFC 1/3] cfg80211: handle wiphy, use wiphy in netdev, do wiphy sysfs Johannes Berg
2006-11-22 19:24         ` [RFC 2/3] d80211: use new wiphy stuff from cfg80211 Johannes Berg
2006-11-22 19:25         ` [RFC 3/3] bcm43xx: API update Johannes Berg
2006-12-11 13:03         ` [RFC 0/3] more power to cfg80211 Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1163894684.15473.8.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=david.kimdon@devicescape.com \
    --cc=flamingice@sourmilk.net \
    --cc=hong.liu@intel.com \
    --cc=ivdoorn@gmail.com \
    --cc=jbenc@suse.cz \
    --cc=jkm@devicescape.com \
    --cc=linville@tuxdriver.com \
    --cc=mbuesch@freenet.de \
    --cc=netdev@vger.kernel.org \
    --cc=simon@devicescape.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).