From: Dan Williams <dcbw@redhat.com>
To: David Kimdon <david.kimdon@devicescape.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>, netdev@vger.kernel.org
Subject: Re: d80211: RFC: divide by zero when hw->maxssi not set
Date: Sun, 19 Nov 2006 18:55:23 -0500 [thread overview]
Message-ID: <1163980523.2881.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20061117235109.GA11885@devicescape.com>
On Fri, 2006-11-17 at 15:51 -0800, David Kimdon wrote:
> Hi,
>
> commit 448bf25bc9e3d70a211fdf235426472089371c43 added
> ieee80211_get_wireless_stats in net/d80211/ieee80211_ioctl.c. At
> present we get a divide by zero (oops) if the low level driver does
> not set the new hw->maxssi field. Perhaps:
>
> - reject registration of devices which do not set maxssi
> - do not attempt to report link quality for drivers which do not
> set maxssi
> - other ideas?
#1 could be too draconian, but has the benefit of making driver writers
put _something_ there. Either way, it's pretty obvious to anyone that
the driver is broken for quality reporting. But at least #1 forces the
issue to making quality somewhat work.
Dan
> -David
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2006-11-19 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 23:51 d80211: RFC: divide by zero when hw->maxssi not set David Kimdon
2006-11-17 23:59 ` Michael Wu
2006-11-19 23:55 ` Dan Williams [this message]
2006-11-20 12:45 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163980523.2881.33.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=david.kimdon@devicescape.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).