On Wed, 2006-11-22 at 17:59 +0100, Ivo van Doorn wrote:

> This patch adds the ethtool_ops reference into the
> ieee80211_ops structure, and makes sure that it will
> be set on all new interfaces that will be created.

I disagree. Most ethtool ops are really tied to actual ethernet (TSO or
UFO for wireless?) and make no sense to have on wireless devices. From
what I can tell, you're using

 (a) get_link
 (b) eeprom dump
 (c) message level
 (d) driver info
 (e) register dump
 (f) get perm addr

(f) will be added to the wiphy stuff in cfg80211/nl80211. (a) has a bit
of a semantic problem, when, for example, does an access point or
monitor device have carrier/lower level ok?

(b) and (e) can be in debugfs, (c) can be a sysfs-modifiable module
parameter.

That leaves just (d) which isn't all that useful anyway.

I just don't see why the ethtool ops should be there at all.

johannes