From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: Krisztian <hidden@balabit.hu>,
netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: RFC: XFRM changing the view of xfrm_aevent_id
Date: Fri, 01 Dec 2006 09:37:52 -0500 [thread overview]
Message-ID: <1164983872.3562.45.camel@localhost> (raw)
while trying to patch iproute2 to display the xfrm aevents i came to the
conclusion that the xfrm_aevent_id struct didnt provide enough info
for me to uniquely identify an SA.
I need two other items: the reqid and saddr.
The structure currently looks like
struct xfrm_aevent_id {
struct xfrm_usersa_id sa_id;
__u32 flags;
};
I could add the two items mentioned above in it and break the ABI.
This may sound dangerous, but the usage of this ABI is not widespread.
AFAIK, the only other person who might have used this is Kristzian (on
CC).
If this is considered evil, then i will transfer the two items in
a new TLV but it wont be as pretty.
Thoughts?
cheers,
jamal
next reply other threads:[~2006-12-01 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 14:37 jamal [this message]
2006-12-01 14:47 ` RFC: XFRM changing the view of xfrm_aevent_id KOVACS Krisztian
2006-12-02 4:08 ` David Miller
2006-12-02 11:09 ` jamal
2006-12-03 6:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164983872.3562.45.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hidden@balabit.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).