From: jamal <hadi@cyberus.ca>
To: Thomas Graf <tgraf@suug.ch>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [RFC][GENETLINK] move command capabilities to flags
Date: Mon, 04 Dec 2006 08:01:09 -0500 [thread overview]
Message-ID: <1165237269.3664.15.camel@localhost> (raw)
In-Reply-To: <20061204092041.GN8693@postel.suug.ch>
On Mon, 2006-04-12 at 10:20 +0100, Thomas Graf wrote:
> * jamal <hadi@cyberus.ca> 2006-12-02 06:56
> >
> > Dave,
> > If there is no objections on this approach, please apply this patch.
> > Against net-2.6.20
> >
> > cheers,
> > jamal
>
> > This patch moves command capabilities to command flags. Other than
> > being cleaner, saves several bytes.
>
> Is it worth to save these 12 bytes by breaking compatibility?
The savings bytes is one aspect; the other is the cleanliness.
transfering a boolean in that many bits is a little of overkill.
I think it is better to fix it now than later.
I know you mentioned libnl uses it. But that is something you can change
on your side. I dont know of any other app that uses it.
> If you
> really want to do it, remove the obsoleted attribute types, I don't
> like dead bodies laying around :-)
I could resend the patch getting rid of those definitions.
cheers,
jamal
next prev parent reply other threads:[~2006-12-04 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 11:56 [RFC][GENETLINK] move command capabilities to flags jamal
2006-12-04 9:20 ` Thomas Graf
2006-12-04 13:01 ` jamal [this message]
2006-12-04 16:31 ` Thomas Graf
2006-12-04 17:48 ` jamal
2006-12-04 18:00 ` Thomas Graf
2006-12-04 21:07 ` jamal
2006-12-04 21:23 ` Thomas Graf
2006-12-05 3:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165237269.3664.15.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).