netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: davem@davemloft.net
Cc: Thomas Graf <tgraf@suug.ch>, netdev@vger.kernel.org
Subject: [PATCH][GENETLINK] fix misplaced command flags
Date: Wed, 06 Dec 2006 12:02:23 -0500	[thread overview]
Message-ID: <1165424543.3749.2.camel@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 134 bytes --]


fixes something i broke in previous patch. Against net-2.6.20.
BTW, is it just me having problems syncing net-2.6.20?

cheers,
jamal

[-- Attachment #2: genl-flags-p --]
[-- Type: text/plain, Size: 994 bytes --]

[GENETLINK] fix misplaced command flags

The command flags for dump and do were swapped..

Signed-off-by: Jamal Hadi Salim<hadi@cyberus.ca>

---
commit 03b09fc1e8f71a14c661af496941b6de963fddf1
tree 3b3c62e1b5f1db0e75ab383a2ec43173cb0f0efa
parent 49ba7537cec41f0db2500054b5fde3c193c37a97
author Jamal Hadi Salim <hadi@cyberus.ca> Wed, 06 Dec 2006 11:58:34 -0500
committer Jamal Hadi Salim <hadi@cyberus.ca> Wed, 06 Dec 2006 11:58:34 -0500

 net/netlink/genetlink.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index 3e37ea5..a59b7bb 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
@@ -144,9 +144,9 @@ int genl_register_ops(struct genl_family *family, struct genl_ops *ops)
 	}
 
 	if (ops->dumpit)
-		ops->flags |= GENL_CMD_CAP_DO;
-	if (ops->doit)
 		ops->flags |= GENL_CMD_CAP_DUMP;
+	if (ops->doit)
+		ops->flags |= GENL_CMD_CAP_DO;
 	if (ops->policy)
 		ops->flags |= GENL_CMD_CAP_HASPOL;
 

             reply	other threads:[~2006-12-06 17:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-06 17:02 jamal [this message]
2006-12-06 17:23 ` [PATCH][GENETLINK] fix misplaced command flags David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1165424543.3749.2.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).