netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [IPROUTE2 PATCH][GENETLINK] Multicast computation off by one
@ 2006-12-06 17:06 jamal
  0 siblings, 0 replies; only message in thread
From: jamal @ 2006-12-06 17:06 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]

A small typo fixup
BTW, how do you like the subject to look like?

cheers,
jamal

[-- Attachment #2: genl-p1 --]
[-- Type: text/plain, Size: 919 bytes --]

[GENL] Multicast computation off by one

When using the first 32 groups, the multicast group to bit mapping
was off by one.

Signed-off-by: Jamal Hadi Salim

---
commit b883bf2396abc0434b3a63d228593cec80808dbb
tree dba2b9664d88d7a4641d11c6284b984a33d2b47a
parent 288384f22ffafd2d7d888ee45d8dfcf26d3f2b1c
author Jamal Hadi Salim <hadi@cyberus.ca> Tue, 05 Dec 2006 14:13:46 -0500
committer Jamal Hadi Salim <hadi@cyberus.ca> Tue, 05 Dec 2006 14:13:46 -0500

 genl/genl_utils.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/genl/genl_utils.h b/genl/genl_utils.h
index 2f2314b..22e9210 100644
--- a/genl/genl_utils.h
+++ b/genl/genl_utils.h
@@ -16,7 +16,7 @@ extern int genl_ctrl_resolve_family(const char *family);
 /* seems to have dissapeared from netlink.h */
 static inline __u32 nl_mgrp(__u32 group)
 {
-	return group ? 1 << group : 0;
+	return group ? (1 << (group -1)) : 0;
 }
 
 #endif

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-12-06 17:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-06 17:06 [IPROUTE2 PATCH][GENETLINK] Multicast computation off by one jamal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).