From: Johannes Berg <johannes@sipsolutions.net>
To: Ulrich Kunitz <kune@deine-taler.de>
Cc: netdev@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Andrew Morton <akpm@osdl.org>,
dsd@gentoo.org
Subject: Re: [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie
Date: Sun, 10 Dec 2006 18:44:18 +0100 [thread overview]
Message-ID: <1165772658.3131.34.camel@johannes.berg> (raw)
In-Reply-To: <20061210172701.GA29871@p15091797.pureserver.info>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Sun, 2006-12-10 at 18:27 +0100, Ulrich Kunitz wrote:
> ieee80211softmac_wx_get_genie locks the associnfo mutex at
> function exit. This patch fixes it. The patch is against Linus'
> tree (commit af1713e0).
Looks good, I wonder how this slipped in.
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
> ---
> net/ieee80211/softmac/ieee80211softmac_wx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
> index 480d72c..fa2f7da 100644
> --- a/net/ieee80211/softmac/ieee80211softmac_wx.c
> +++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
> @@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net
> err = -E2BIG;
> }
> spin_unlock_irqrestore(&mac->lock, flags);
> - mutex_lock(&mac->associnfo.mutex);
> + mutex_unlock(&mac->associnfo.mutex);
>
> return err;
> }
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2006-12-10 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-10 17:27 [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie Ulrich Kunitz
2006-12-10 17:39 ` Michael Buesch
2006-12-10 17:44 ` Johannes Berg [this message]
2006-12-10 17:51 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165772658.3131.34.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=akpm@osdl.org \
--cc=dsd@gentoo.org \
--cc=kune@deine-taler.de \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).