netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ieee80211: WLAN_GET_SEQ_SEQ fix
@ 2006-12-18  9:26 Zhu Yi
       [not found] ` <4586C6D1.5060607@lwfinger.net>
  0 siblings, 1 reply; 2+ messages in thread
From: Zhu Yi @ 2006-12-18  9:26 UTC (permalink / raw)
  To: netdev, John W. Linville

Signed-off-by: Zhu Yi <yi.zhu@intel.com>

diff --git a/include/net/ieee80211.h b/include/net/ieee80211.h
index e6af381..e02d85f 100644
--- a/include/net/ieee80211.h
+++ b/include/net/ieee80211.h
@@ -218,7 +218,7 @@ struct ieee80211_snap_hdr {
 #define WLAN_FC_GET_STYPE(fc) ((fc) & IEEE80211_FCTL_STYPE)
 
 #define WLAN_GET_SEQ_FRAG(seq) ((seq) & IEEE80211_SCTL_FRAG)
-#define WLAN_GET_SEQ_SEQ(seq)  ((seq) & IEEE80211_SCTL_SEQ)
+#define WLAN_GET_SEQ_SEQ(seq)  (((seq) & IEEE80211_SCTL_SEQ) >> 4)
 
 /* Authentication algorithms */
 #define WLAN_AUTH_OPEN 0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ieee80211: WLAN_GET_SEQ_SEQ fix
       [not found] ` <4586C6D1.5060607@lwfinger.net>
@ 2006-12-19  3:16   ` Zhu Yi
  0 siblings, 0 replies; 2+ messages in thread
From: Zhu Yi @ 2006-12-19  3:16 UTC (permalink / raw)
  To: Larry Finger; +Cc: netdev, John W. Linville

On Mon, 2006-12-18 at 10:50 -0600, Larry Finger wrote:
> 
> Shouldn't this fix have some commit message like "The
> WLAN_GET_SEQ_SEQ(seq) macro in ieee80211 is 
> selecting the wrong region."? That said, the fix conforms with the
> IEEE802.11 specs.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> 

OK. I thought it was obvious.

Thanks,
-yi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-19  3:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-18  9:26 [PATCH] ieee80211: WLAN_GET_SEQ_SEQ fix Zhu Yi
     [not found] ` <4586C6D1.5060607@lwfinger.net>
2006-12-19  3:16   ` Zhu Yi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).