From: Hong Liu <hong.liu@intel.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: "John W. Linville" <linville@tuxdriver.com>,
netdev <netdev@vger.kernel.org>
Subject: [PATCH] d80211: fix softlockup in hw_scan card when rmmod
Date: Wed, 20 Dec 2006 14:43:51 +0800 [thread overview]
Message-ID: <1166597031.22413.11.camel@devlinux-hong> (raw)
The local->scan_work.data is not clear after scan is completed.
This will cause softlockup when removing driver module because
the local->scan_work is not initialized for hw_scan card
and we are trying to cancel the scan_work with an uninitialized timer_list.
Signed-off-by: Hong Liu <hong.liu@intel.com>
diff --git a/net/d80211/ieee80211.c b/net/d80211/ieee80211.c
diff --git a/net/d80211/ieee80211_sta.c b/net/d80211/ieee80211_sta.c
index 507d071..3b55427 100644
--- a/net/d80211/ieee80211_sta.c
+++ b/net/d80211/ieee80211_sta.c
@@ -3641,6 +3641,7 @@ void ieee80211_scan_completed(struct iee
printk(KERN_DEBUG "%s: scan completed\n", dev->name);
spin_lock_bh(&local->ifsta_data_lock);
local->sta_scanning = 0;
+ local->scan_work.data = NULL;
local->last_scan_completed = jiffies;
spin_unlock_bh(&local->ifsta_data_lock);
next reply other threads:[~2006-12-20 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 6:43 Hong Liu [this message]
2006-12-20 12:21 ` [PATCH] d80211: fix softlockup in hw_scan card when rmmod Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166597031.22413.11.camel@devlinux-hong \
--to=hong.liu@intel.com \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).