From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: eric.lemoine@gmail.com, netdev@vger.kernel.org
Subject: Re: [patch sungem] improved locking
Date: Sat, 30 Dec 2006 08:36:07 +1100 [thread overview]
Message-ID: <1167428167.23340.114.camel@localhost.localdomain> (raw)
In-Reply-To: <20061228.210546.55150331.davem@davemloft.net>
On Thu, 2006-12-28 at 21:05 -0800, David Miller wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date: Wed, 13 Dec 2006 15:07:24 +1100
>
> > tg3 says
> >
> > tg3: eth0: Link is up at 1000 Mbps, full duplex.
> > tg3: eth0: Flow control is on for TX and on for RX.
> >
> > but sungem says
> >
> > eth0: Link is up at 1000 Mbps, full-duplex.
> > eth0: Pause is disabled
> >
> > Hrm... I suppose I need to dig more. No time to do that today though.
>
> I was about to try and debug this, and noticed immediately that I
> didn't recognize any of the code.
>
> Could you look into this, you rewrote all of this stuff and this
> looks like a regression added, because I know this pause stuff
> used to work perfectly when I wrote the original GEM driver. :-)
Heh, it's very possible it's a regression I added indeed. I'll try to
have a look next week. Do you know of anybody who can verify on non-mii
hardware or is pause irrelevant there ?
Ben.
next prev parent reply other threads:[~2006-12-29 21:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 21:33 [patch sungem] improved locking Eric Lemoine
2006-11-09 23:04 ` David Miller
2006-11-10 13:28 ` Eric Lemoine
2006-11-10 20:37 ` Benjamin Herrenschmidt
2006-11-10 20:42 ` David Miller
2006-11-12 23:11 ` Eric Lemoine
2006-11-14 0:46 ` David Miller
2006-11-14 7:28 ` Eric Lemoine
2006-11-14 7:44 ` David Miller
2006-11-14 21:54 ` Eric Lemoine
2006-11-28 22:49 ` David Miller
2006-11-28 22:57 ` Benjamin Herrenschmidt
2006-11-28 23:43 ` David Miller
2006-11-29 0:19 ` Benjamin Herrenschmidt
2006-11-29 10:16 ` Eric Lemoine
2006-11-29 10:56 ` Eric Lemoine
2006-11-29 22:37 ` Eric Lemoine
2006-12-13 3:12 ` Benjamin Herrenschmidt
2006-12-13 3:24 ` Benjamin Herrenschmidt
2006-12-13 4:03 ` David Miller
2006-12-13 4:07 ` Benjamin Herrenschmidt
2006-12-29 5:05 ` David Miller
2006-12-29 21:36 ` Benjamin Herrenschmidt [this message]
2006-12-29 23:20 ` David Miller
2006-12-12 1:43 ` David Miller
2006-12-12 5:33 ` Eric Lemoine
2006-12-12 5:36 ` Benjamin Herrenschmidt
2006-12-12 5:49 ` Eric Lemoine
2006-12-15 0:59 ` Benjamin Herrenschmidt
2006-12-18 1:15 ` David Miller
2006-12-18 1:41 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1167428167.23340.114.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=eric.lemoine@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).