From: Pavel Roskin <proski-mXXj517/zsQ@public.gmane.org>
To: bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [RFC PATCH] bcm43xx: set channel when the interface is brought up
Date: Thu, 25 Jan 2007 01:50:54 -0500 [thread overview]
Message-ID: <1169707854.10593.41.camel@dv> (raw)
Hello!
I have discovered that while I can indeed associate without
wpa_supplicant using bcm43xx_d80211 driver, I have to set the channel
every time the interface is brought down and up.
It turns out d80211 uses the "config" method of the hardware drivers
very sparingly. It's only used for scanning and in ioctl commands. It
is not called after the interface has been brought up with the "open"
method.
I don't know whose responsibility it should be to apply the
configuration when the interface is brought up. I'm not familiar with
d80211 design principles.
If the hardware drivers are supposed to do it, here's my patch. It is
working fine for me and ready to be applied. The changelog is in the
subject.
Signed-off-by: Pavel Roskin <proski-mXXj517/zsQ@public.gmane.org>
---
drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
index 9f4d51d..d408e38 100644
--- a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
@@ -2809,6 +2809,9 @@ static int bcm43xx_dev_open(struct ieee80211_hw *hw)
}
mutex_unlock(&wl->mutex);
+ if (!err)
+ err = bcm43xx_dev_config(hw, &hw->conf);
+
return err;
}
--
Regards,
Pavel Roskin
next reply other threads:[~2007-01-25 6:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 6:50 Pavel Roskin [this message]
2007-01-25 9:30 ` [RFC PATCH] bcm43xx: set channel when the interface is brought up Jiri Benc
2007-01-25 11:47 ` Ivo Van Doorn
2007-01-25 12:50 ` Jiri Benc
2007-01-25 12:57 ` Ivo Van Doorn
[not found] ` <20070125135033.7d7d7baf-IhiK2ZEFs2oCVLCxKZUutA@public.gmane.org>
2007-01-25 14:05 ` Gene Heskett
2007-01-25 14:23 ` Jiri Benc
[not found] ` <20070125152321.434bb17c-IhiK2ZEFs2oCVLCxKZUutA@public.gmane.org>
2007-01-25 14:34 ` Gene Heskett
2007-01-26 13:45 ` Johannes Berg
2007-01-25 15:36 ` Larry Finger
2007-01-25 16:26 ` Dan Williams
2007-01-25 16:51 ` Michael Wu
2007-01-25 20:12 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169707854.10593.41.camel@dv \
--to=proski-mxxj517/zsq@public.gmane.org \
--cc=bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).