From: Pavel Roskin <proski@gnu.org>
To: Jiri Benc <jbenc@suse.cz>
Cc: netdev@vger.kernel.org
Subject: Re: d80211: a patch for standalone d80211 tarball
Date: Mon, 29 Jan 2007 15:23:07 -0500 [thread overview]
Message-ID: <1170102187.12657.9.camel@dv> (raw)
In-Reply-To: <20070129174812.7D1E94849E@silver.suse.cz>
Hi, Jiri!
On Mon, 2007-01-29 at 18:48 +0100, Jiri Benc wrote:
> +#define register_invisible_netdevice register_netdevice
> +#define unregister_invisible_netdevice unregister_netdevice
Please use macros with arguments whenever possible. This way, incorrect
macro invocations would be detected even if the original prototype is
missing. Also, the macro name could be used without arguments for other
purposes (variable, gcc attribute etc).
Both cases are highly unlikely for the above macros, but please keep in
mind that some aspiring programmers view the kernel as an example of
good programming style.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2007-01-29 20:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-29 17:48 [RFC PATCH 1/6] invisible network devices Jiri Benc
2007-01-29 17:48 ` [PATCH 2/6] d80211: use invisible network device for wmaster Jiri Benc
2007-01-29 17:48 ` [PATCH 3/6] d80211: drop packets from nonexisting interfaces in PS mode Jiri Benc
2007-01-29 17:48 ` [PATCH 4/6] d80211: don't display name of invisible network device Jiri Benc
2007-01-30 13:47 ` Johannes Berg
2007-01-30 14:00 ` Jan Kiszka
2007-01-31 18:58 ` Johannes Berg
2007-02-01 15:17 ` Jiri Benc
2007-02-01 15:19 ` Johannes Berg
2007-01-29 17:48 ` [PATCH 5/6] d80211: remove useless callbacks from wmaster Jiri Benc
2007-01-29 17:48 ` [PATCH 6/6] d80211: fix rtnl locking in ieee80211_register_hw Jiri Benc
2007-01-29 17:48 ` d80211: a patch for standalone d80211 tarball Jiri Benc
2007-01-29 18:34 ` Ivo Van Doorn
2007-01-29 20:23 ` Pavel Roskin [this message]
2007-01-31 18:06 ` Jiri Benc
2007-01-29 18:28 ` [RFC PATCH 1/6] invisible network devices Stephen Hemminger
2007-01-29 22:09 ` [RFC] Alternative hidden netwirk device interface Stephen Hemminger
2007-01-30 10:09 ` Christoph Hellwig
2007-01-31 18:26 ` Jiri Benc
2007-01-31 18:40 ` Stephen Hemminger
2007-02-21 8:04 ` David Miller
2007-01-30 10:08 ` [RFC PATCH 1/6] invisible network devices Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170102187.12657.9.camel@dv \
--to=proski@gnu.org \
--cc=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).