From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [Cbe-oss-dev] spidernet: dynamic phy setup code Date: Mon, 05 Feb 2007 10:44:32 +1100 Message-ID: <1170632672.2620.47.camel@localhost.localdomain> References: <200702010805.l11853LX014768@toshiba.co.jp> <200702011204.30526.jens@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, jgarzik@pobox.com, jim@jklewis.com To: Jens Osterkamp Return-path: In-Reply-To: <200702011204.30526.jens@de.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org List-Id: netdev.vger.kernel.org On Thu, 2007-02-01 at 12:04 +0100, Jens Osterkamp wrote: > Ishizaki-san, > > > This patch partially works on celleb but remains > > following several problems. > > 1. It doesn't recover once an ethernet cable which is > > connected to a spider_net card is unpluged. > > My understanding is that you are using the LINK interrupt to detect this. > For the blade this is not connected but reenabling it wont hurt, I hope. I would suggest just polling from a delayed work or a timer like sungem does. > I still dont see why you need different settings for different speed switches. > This is getting to a point where access to some hardware would be handy. > What exact phy are using anyway ? Yeah, same question... > > Furthermore, we have a problem that poll_link() may succeed even when > > the auto-neg initial setting is for different network switch type, > > and the network card does not work on this case. We retry auto-neg > > with the another initial setting on this case. > > See above, could you give some more details why this is the case. Or maybe Ben > knows more about this ? No, I'm surprised too. Ben.