From: Max Krasnyansky <maxk@qualcomm.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Max Krasnyansky <maxk@qualcomm.com>
Subject: [TIPC] Missing null check in the socket code.
Date: Thu, 15 Feb 2007 22:27:34 -0800 [thread overview]
Message-ID: <11716072541171-git-send-email-maxk@qualcomm.com> (raw)
In-Reply-To: <1171607254637-git-send-email-maxk@qualcomm.com>
Fixes an oops in the non-blocking mode.
Signed-off-by: Max Krasnyansky <maxk@qualcomm.com>
---
net/tipc/socket.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 2a6a5a6..767f791 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -862,6 +862,10 @@ restart:
/* Get access to first message in receive queue */
buf = skb_peek(&sock->sk->sk_receive_queue);
+ if (NULL == buf) {
+ res = -EAGAIN;
+ goto exit;
+ }
msg = buf_msg(buf);
sz = msg_data_sz(msg);
err = msg_errcode(msg);
--
1.4.4.2
next prev parent reply other threads:[~2007-02-16 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 6:27 [TIPC] Properly mask header fields Max Krasnyansky
2007-02-16 6:27 ` Max Krasnyansky [this message]
2007-02-20 18:48 ` [TIPC] Missing null check in the socket code Max Krasnyansky
2007-02-21 14:02 ` Jon Maloy (QB/EMC)
2007-02-21 21:22 ` Max Krasnyansky
2007-02-20 18:47 ` [TIPC] Properly mask header fields Max Krasnyansky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11716072541171-git-send-email-maxk@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).