netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: shemminger@osdl.org, netdev@vger.kernel.org, ebs@ebshome.net,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] split NAPI from network device.
Date: Thu, 22 Feb 2007 10:24:31 +1100	[thread overview]
Message-ID: <1172100271.6792.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20070220.213125.74747066.davem@davemloft.net>


> Actually, Ben did you determine if this scheme works for your device
> which has a single interrupt source yet multiple queues?  There is one
> driver that, during the conversion, I noticed has a similar issue.
> One driver, netxen, has multiple channels, so it just passes in
> "bugdet / NUM_CHANNELS" as the quota so that one channel could not
> starve the others.


The device has a single interrupt though that interrupt at least can
tell you which queues need servicing. It can't mask the interrupt per
queue though, which is the main issue.

So while I think this scheme would work (the driver, ibm_emac, currently
uses a fake net_device and that sort-of works, budget is set a CONFIG_*
time though, I'm sure that can/needs to be improved), I've been
wondering all along if I could do something smarter by doing some
interrupt soft-disabling instead, though I have to get my head around
properly kicking softirqs from task context (if I need to re-trigger
from a enable_*() call occuring at task context).

I'm travelling at the moment, so I won't be able to have a serious look
for a little while though.

Cheers,
Ben.
 


  parent reply	other threads:[~2007-02-21 23:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-12  5:27 [PATCH] add init_dummy_netdev() for napi only dummy intefaces Benjamin Herrenschmidt
2006-12-13 19:35 ` Stephen Hemminger
2006-12-13 20:42   ` Benjamin Herrenschmidt
2006-12-13 21:06     ` Stephen Hemminger
2006-12-13 23:46     ` [RFC] split NAPI from network device Stephen Hemminger
2006-12-14 20:01       ` Benjamin Herrenschmidt
2007-02-21  5:31       ` David Miller
2007-02-21  7:39         ` Divy Le Ray
2007-02-21  7:47           ` David Miller
2007-02-21 23:24         ` Benjamin Herrenschmidt [this message]
2007-02-22 11:18           ` David Miller
2007-02-22 12:24         ` Divy Le Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1172100271.6792.7.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=ebs@ebshome.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).