netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Missing VLAN tags in bnx2
@ 2007-02-28 19:12 Pekka Pietikainen
  2007-03-01  1:27 ` Michael Chan
  0 siblings, 1 reply; 2+ messages in thread
From: Pekka Pietikainen @ 2007-02-28 19:12 UTC (permalink / raw)
  To: netdev, mchan

Just had to spend some time figuring out why a bnx2 card connected to
a switch monitor port didn't see any vlan tags (when in our scenario the
tags are pretty vital).  Found the following explanation:

[BNX2]: Fix VLAN on ASF
    
    Always set up the device to strip incoming VLAN tags when ASF is
    enabled. ASF firmware will not parse packets correctly if VLAN tags
    are not stripped

My fix:

#ifdef I_DONT_KNOW_WHAT_ASF_IS_AND_DONT_REALLY_CARE_EITHER
        if (REG_RD_IND(bp, bp->shmem_base + BNX2_PORT_FEATURE) &
            BNX2_PORT_FEATURE_ASF_ENABLED)
                bp->flags |= ASF_ENABLE_FLAG;
#endif

Any hope of getting this as a ethtool tunable or something similar?
There didn't seem to be a BIOS option for this (Dell PE2900), at least.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-03-01  0:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-28 19:12 Missing VLAN tags in bnx2 Pekka Pietikainen
2007-03-01  1:27 ` Michael Chan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).