From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: David Miller <davem@davemloft.net>, avinash.repaka@oracle.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables
Date: Mon, 2 Oct 2017 13:30:43 -0700 [thread overview]
Message-ID: <1172819f-1c28-7756-4874-aa89f50c0733@oracle.com> (raw)
In-Reply-To: <20171001.225655.1261950191787562705.davem@davemloft.net>
On 10/1/2017 10:56 PM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sun, 01 Oct 2017 22:54:19 -0700 (PDT)
>
>> From: Avinash Repaka <avinash.repaka@oracle.com>
>> Date: Fri, 29 Sep 2017 18:13:50 -0700
>>
>>> This patch fixes the scope of has_fr and has_fmr variables as they are
>>> needed only in rds_ib_add_one().
>>>
>>> Signed-off-by: Avinash Repaka <avinash.repaka@oracle.com>
>>
>> Applied.
>
> Actually, reverted, this breaks the build.
>
> net/rds/rdma_transport.c:38:10: fatal error: ib.h: No such file or directory
> #include "ib.h"
>
> Although I can't see how in the world this patch is causing such
> an error.
>
Weird indeed. Will sort this out with Avinash. Thanks Dave.
Regards,
Santosh
next prev parent reply other threads:[~2017-10-02 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 1:13 [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables Avinash Repaka
2017-09-30 1:38 ` Santosh Shilimkar
[not found] ` <1506734030-15205-1-git-send-email-avinash.repaka-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-10-02 5:54 ` David Miller
[not found] ` <20171001.225419.1632354964848604960.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-10-02 5:56 ` David Miller
2017-10-02 20:30 ` Santosh Shilimkar [this message]
[not found] ` <1172819f-1c28-7756-4874-aa89f50c0733-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-10-04 0:42 ` Santosh Shilimkar
[not found] ` <d1f841a7-0c1d-9d20-ee33-6e260b5d84c4-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-10-04 4:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172819f-1c28-7756-4874-aa89f50c0733@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=avinash.repaka@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).