s390 allmodconfig

s390 allmodconfig

[Andrew Morton]

Not sure who to blame for all of this...

net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' refer to undefined symbol 'HID'
net/mac80211/Kconfig:17:warning: 'select' used by config symbol 'MAC80211_LEDS' refer to undefined symbol 'NEW_LEDS'
net/mac80211/Kconfig:18:warning: 'select' used by config symbol 'MAC80211_LEDS' refer to undefined symbol 'LEDS_TRIGGERS'
drivers/net/Kconfig:1435:warning: 'select' used by config symbol 'B44' refer to undefined symbol 'SSB'
drivers/net/wireless/bcm43xx/Kconfig:5:warning: 'select' used by config symbol 'BCM43XX' refer to undefined symbol 'HW_RANDOM'
drivers/net/wireless/mac80211/bcm43xx/Kconfig:13:warning: 'select' used by config symbol 'BCM43XX_MAC80211_PCI' refer to undefined symbol 'SSB_PCIHOST'
drivers/net/wireless/mac80211/bcm43xx/Kconfig:14:warning: 'select' used by config symbol 'BCM43XX_MAC80211_PCI' refer to undefined symbol 'SSB_DRIVER_PCICORE'
drivers/net/wireless/mac80211/bcm43xx/Kconfig:27:warning: 'select' used by config symbol 'BCM43XX_MAC80211_PCMCIA' refer to undefined symbol 'SSB_PCMCIAHOST'
drivers/net/wireless/mac80211/bcm43xx/Kconfig:5:warning: 'select' used by config symbol 'BCM43XX_MAC80211' refer to undefined symbol 'SSB'

Re: s390 allmodconfig

[Andrew Morton]

net/mac80211/ieee80211_led.c: In function 'ieee80211_led_init':
net/mac80211/ieee80211_led.c:38: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger' 
net/mac80211/ieee80211_led.c:43: error: dereferencing pointer to incomplete type
net/mac80211/ieee80211_led.c:44: warning: implicit declaration of function 'led_trigger_register'
net/mac80211/ieee80211_led.c:49: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger' 
net/mac80211/ieee80211_led.c:54: error: dereferencing pointer to incomplete type
net/mac80211/ieee80211_led.c: In function 'ieee80211_led_exit':
net/mac80211/ieee80211_led.c:64: warning: implicit declaration of function 'led_trigger_unregister'

akpm2:/usr/src/25> grep LED .config
CONFIG_NF_CONNTRACK_ENABLED=m
CONFIG_MAC80211_LEDS=y

Probably related to the Kconfig problems.

Re: s390 allmodconfig

[Richard Purdie]

On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:
> net/mac80211/ieee80211_led.c: In function 'ieee80211_led_init':
> net/mac80211/ieee80211_led.c:38: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger' 
> net/mac80211/ieee80211_led.c:43: error: dereferencing pointer to incomplete type
> net/mac80211/ieee80211_led.c:44: warning: implicit declaration of function 'led_trigger_register'
> net/mac80211/ieee80211_led.c:49: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger' 
> net/mac80211/ieee80211_led.c:54: error: dereferencing pointer to incomplete type
> net/mac80211/ieee80211_led.c: In function 'ieee80211_led_exit':
> net/mac80211/ieee80211_led.c:64: warning: implicit declaration of function 'led_trigger_unregister'
> 
> akpm2:/usr/src/25> grep LED .config
> CONFIG_NF_CONNTRACK_ENABLED=m
> CONFIG_MAC80211_LEDS=y
> 
> Probably related to the Kconfig problems.

Almost certainly. Someone is building some LED trigger/driver without
the LED core enabled which is what that Kconfig warning was about.

Nobody's ever mentioned this driver to me...

Richard
(LED Maintainer)

Re: s390 allmodconfig

[Johannes Berg]

On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:

> Probably related to the Kconfig problems.

Yeah, it is. s390 is funny, it doesn't include drivers/Kconfig, I don't
think anybody of us would have suspected that.

There doesn't seem to be a reason why it shouldn't have drivers/leds
though. drivers/ssb I don't know about, does s390 have pci or pcmcia?
And the bluetooth stuff is also plain weird, I suppose s390 really
should include drivers/hid/Kconfig :)

Same with drivers/char that includes hw_random.

Is there any reason it isn't including drivers/Kconfig? 


I can offer below patch to fix the LED trigger problem, it's probably
cleaner to depend on LEDS_TRIGGERS rather than selecting it and
NEW_LEDS.

johannes

--- wireless-dev.orig/net/mac80211/Kconfig	2007-03-02 11:18:45.464333268 +0100
+++ wireless-dev/net/mac80211/Kconfig	2007-03-02 11:33:24.534333268 +0100
@@ -13,9 +13,7 @@ config MAC80211
 
 config MAC80211_LEDS
 	bool "Enable LED triggers"
-	depends on MAC80211
-	select NEW_LEDS
-	select LEDS_TRIGGERS
+	depends on MAC80211 && LEDS_TRIGGERS
 	---help---
 	This option enables a few LED triggers for different
 	packet receive/transmit events.

Re: s390 allmodconfig

[Andrew Morton]

On Fri, 02 Mar 2007 10:32:32 +0000 Richard Purdie <rpurdie@rpsys.net> wrote:

> On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:
> > net/mac80211/ieee80211_led.c: In function 'ieee80211_led_init':
> > net/mac80211/ieee80211_led.c:38: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger' 
> > net/mac80211/ieee80211_led.c:43: error: dereferencing pointer to incomplete type
> > net/mac80211/ieee80211_led.c:44: warning: implicit declaration of function 'led_trigger_register'
> > net/mac80211/ieee80211_led.c:49: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger' 
> > net/mac80211/ieee80211_led.c:54: error: dereferencing pointer to incomplete type
> > net/mac80211/ieee80211_led.c: In function 'ieee80211_led_exit':
> > net/mac80211/ieee80211_led.c:64: warning: implicit declaration of function 'led_trigger_unregister'
> > 
> > akpm2:/usr/src/25> grep LED .config
> > CONFIG_NF_CONNTRACK_ENABLED=m
> > CONFIG_MAC80211_LEDS=y
> > 
> > Probably related to the Kconfig problems.
> 
> Almost certainly. Someone is building some LED trigger/driver without
> the LED core enabled which is what that Kconfig warning was about.
> 
> Nobody's ever mentioned this driver to me...
> 

It's a mountain of new wireless code in the just-released 2.6.21-rc2-mm1.

Re: s390 allmodconfig

[Andrew Morton]

On Fri, 02 Mar 2007 11:38:24 +0100 Johannes Berg <johannes@sipsolutions.net> wrote:

> On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:
> 
> > Probably related to the Kconfig problems.
> 
> Yeah, it is. s390 is funny, it doesn't include drivers/Kconfig, I don't
> think anybody of us would have suspected that.
> 
> There doesn't seem to be a reason why it shouldn't have drivers/leds
> though. drivers/ssb I don't know about, does s390 have pci or pcmcia?

No, s390 doesn't have PCI.

> And the bluetooth stuff is also plain weird, I suppose s390 really
> should include drivers/hid/Kconfig :)
> 
> Same with drivers/char that includes hw_random.
> 
> Is there any reason it isn't including drivers/Kconfig? 
> 

s390 is weird ;)   There's no way it'll support any of the hardware which you're
working on (until they release the s390 laptop).  So all we really want to
do here is to avoid breaking s390 allmodconfig.
 
> I can offer below patch to fix the LED trigger problem, it's probably
> cleaner to depend on LEDS_TRIGGERS rather than selecting it and
> NEW_LEDS.
> 
> johannes
> 
> --- wireless-dev.orig/net/mac80211/Kconfig	2007-03-02 11:18:45.464333268 +0100
> +++ wireless-dev/net/mac80211/Kconfig	2007-03-02 11:33:24.534333268 +0100
> @@ -13,9 +13,7 @@ config MAC80211
>  
>  config MAC80211_LEDS
>  	bool "Enable LED triggers"
> -	depends on MAC80211
> -	select NEW_LEDS
> -	select LEDS_TRIGGERS
> +	depends on MAC80211 && LEDS_TRIGGERS
>  	---help---
>  	This option enables a few LED triggers for different
>  	packet receive/transmit events.

OK, I'll try that, thanks.

Re: s390 allmodconfig

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

On Fri, 2007-03-02 at 03:06 -0800, Andrew Morton wrote:

> No, s390 doesn't have PCI.

Ok.

> s390 is weird ;)   There's no way it'll support any of the hardware which you're
> working on (until they release the s390 laptop).  So all we really want to
> do here is to avoid breaking s390 allmodconfig.

Alright. I think we'll probably have to make bcm43xx and b44 depend on
SSB instead of selecting it like the LED trigger stuff below.

But I don't see why s390 can't include hw random, led trigger or even
hid, those are all software features afaict.
 

> OK, I'll try that, thanks.

Not that it'll actually help get the compile through... bcm43xx will
drop fail and bluetooth probably as well.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: s390 allmodconfig

[Andrew Morton]

On Fri, 02 Mar 2007 12:11:48 +0100 Johannes Berg <johannes@sipsolutions.net> wrote:

> On Fri, 2007-03-02 at 03:06 -0800, Andrew Morton wrote:
> 
> > No, s390 doesn't have PCI.
> 
> Ok.
> 
> > s390 is weird ;)   There's no way it'll support any of the hardware which you're
> > working on (until they release the s390 laptop).  So all we really want to
> > do here is to avoid breaking s390 allmodconfig.
> 
> Alright. I think we'll probably have to make bcm43xx and b44 depend on
> SSB instead of selecting it like the LED trigger stuff below.
> 
> But I don't see why s390 can't include hw random, led trigger or even
> hid, those are all software features afaict.
>  
> 
> > OK, I'll try that, thanks.
> 
> Not that it'll actually help get the compile through... bcm43xx will
> drop fail and bluetooth probably as well.
> 

OK, thanks.

fwiw, http://userweb.kernel.org/~akpm/cross-compilers/ has an s390
cross-compiler binary.

Re: s390 allmodconfig

[Martin Schwidefsky]

On Fri, 2007-03-02 at 12:11 +0100, Johannes Berg wrote:
> On Fri, 2007-03-02 at 03:06 -0800, Andrew Morton wrote:
> > s390 is weird ;)   There's no way it'll support any of the hardware which you're
> > working on (until they release the s390 laptop).  So all we really want to
> > do here is to avoid breaking s390 allmodconfig.

Well, I would not say "weird" but different. None of the usual device
attachments is present on a s390. That includes memory mapped i/o (!).

> Alright. I think we'll probably have to make bcm43xx and b44 depend on
> SSB instead of selecting it like the LED trigger stuff below.
> 
> But I don't see why s390 can't include hw random, led trigger or even
> hid, those are all software features afaict.

True. I'm still sitting on a couple of patches that make s390 use the
standard drivers/Kconfig. The downside of these patches is that I have
to add a lot of "depends on !S390" all over the place.

> > OK, I'll try that, thanks.
> 
> Not that it'll actually help get the compile through... bcm43xx will
> drop fail and bluetooth probably as well.

No bcm43xx, no bluetooth on s390..

-- 
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.